Skip to content

refactor: introduce payjoin_directory::Service#914

Merged
spacebear21 merged 1 commit intopayjoin:masterfrom
nothingmuch:directory-service-struct
Aug 4, 2025
Merged

refactor: introduce payjoin_directory::Service#914
spacebear21 merged 1 commit intopayjoin:masterfrom
nothingmuch:directory-service-struct

Conversation

@nothingmuch
Copy link
Copy Markdown
Contributor

This is a preparatory change to avoid tight coupling to redis as a storage backend, and to enable ACME support by simplifying the listener logic.

  • implements hyper::Service trait
  • Arc<Mutexohttp::Server> -> ohttp::Server
  • remove serve_payjoin_directory function
  • simplify and remove various listen helpers

Copy link
Copy Markdown
Collaborator

@spacebear21 spacebear21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, very nice refactor.

Comment thread payjoin-directory/src/config.rs Outdated
Comment thread payjoin-directory/src/lib.rs Outdated
Comment thread payjoin-test-utils/src/lib.rs
This is a preparatory change to avoid tight coupling to redis as a
storage backend, and to enable ACME support by simplifying the listener
logic.

- implements hyper::Service trait
- Arc<Mutex<ohttp::Server>> -> ohttp::Server
- remove serve_payjoin_directory function
- simplify and remove various listen helpers
@nothingmuch nothingmuch force-pushed the directory-service-struct branch from ca6fc8c to c173a25 Compare August 4, 2025 14:02
Copy link
Copy Markdown
Collaborator

@spacebear21 spacebear21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c173a25

@spacebear21 spacebear21 merged commit d68eab9 into payjoin:master Aug 4, 2025
10 checks passed
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Aug 4, 2025

Pull Request Test Coverage Report for Build 16725345224

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 208 of 250 (83.2%) changed or added relevant lines in 3 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 86.192%

Changes Missing Coverage Covered Lines Changed/Added Lines %
payjoin-directory/src/main.rs 0 9 0.0%
payjoin-directory/src/lib.rs 197 230 85.65%
Files with Coverage Reduction New Missed Lines %
payjoin-directory/src/main.rs 1 0.0%
payjoin-directory/src/lib.rs 4 67.05%
Totals Coverage Status
Change from base Build 16682297890: 0.2%
Covered Lines: 7996
Relevant Lines: 9277

💛 - Coveralls

@nothingmuch nothingmuch mentioned this pull request Aug 7, 2025
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants