Add amount to recv session context#920
Merged
spacebear21 merged 1 commit intopayjoin:masterfrom Aug 12, 2025
Merged
Conversation
Collaborator
Pull Request Test Coverage Report for Build 16836032368Details
💛 - Coveralls |
d71dbcc to
2de392c
Compare
Collaborator
Author
|
Unfortunately the dart tests are failing on my machine for a different reason |
Currently application developers are having to apply the amount to the bip21 uri outside of the API. https://github.com/payjoin/rust-payjoin/blob/5ecfed745bd33f6d5706f497bdb7662a3a7c9177/payjoin-cli/src/app/v2/mod.rs#L112-L113 This is a convenience that allows amount to be already applied to the bip21. It also allows us to capture this information in the session history.
2de392c to
4926384
Compare
Collaborator
Author
|
Per a recommendation I ran |
Collaborator
|
Lol first try. Tested on 4926384 |
spacebear21
approved these changes
Aug 12, 2025
Collaborator
spacebear21
left a comment
There was a problem hiding this comment.
ACK 4926384
Thanks for ensuring the Dart tests pass! I'm hopeful the flakiness will be fixed soon.
arminsabouri
referenced
this pull request
Aug 13, 2025
Make max_fee_rate persistent across payjoin session resumptions
and simplify FFI layer architecture by eliminating duplicate fee
rate capping logic.
- Add max_fee_rate field to SessionContext with serde defaults for
backward compatibility
- Remove session_max_fee_rate() accessor method (no longer needed)
- Simplify FFI layer to convert Option<u64> to Option<FeeRate> and
pass directly to core apply_fee_range() method
- Eliminate code duplication between FFI and core layers
- Maintain all fee rate capping logic in core library only
Fixes #897
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently application developers are having to apply the amount to the
bip21 uri outside of the API.
rust-payjoin/payjoin-cli/src/app/v2/mod.rs
Lines 112 to 113 in 5ecfed7
This is a convenience that allows amount to be already applied to the
bip21. It also allows us to capture this information in the session
history.
Related ticket: #895