Make max fee rate sticky per payjoin-cli session#933
Closed
Johnosezele wants to merge 0 commit intopayjoin:masterfrom
Closed
Make max fee rate sticky per payjoin-cli session#933Johnosezele wants to merge 0 commit intopayjoin:masterfrom
Johnosezele wants to merge 0 commit intopayjoin:masterfrom
Conversation
Johnosezele
force-pushed
the
sticky-max-feerate-receiver-context
branch
2 times, most recently
from
c419adf to
fbaa404
Compare
Johnosezele
force-pushed
the
sticky-max-feerate-receiver-context
branch
from
fbaa404 to
0aa1509
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a payjoin-cli receive session is created, the max_fee_rate is now persisted with the session and reused when the session is resumed, instead of defaulting to the global configuration value.
This implementation adds
max_fee_rateas a non-optional field to theSessionWrapperandSessionContextstructs, with backward compatibility ensured through serde defaults. CLI users can still override the stored fee rate by providing --max-fee-rate when resuming.Resolves: #897