Skip to content

Upgrade testcontainers#970

Merged
spacebear21 merged 1 commit intopayjoin:masterfrom
spacebear21:upgrade-testcontainers
Aug 18, 2025
Merged

Upgrade testcontainers#970
spacebear21 merged 1 commit intopayjoin:masterfrom
spacebear21:upgrade-testcontainers

Conversation

@spacebear21
Copy link
Copy Markdown
Collaborator

@spacebear21 spacebear21 commented Aug 18, 2025

The current version causes flakiness that are especially apparent in the integration test for dart bindings.

We don't need the testcontainers dependency directly since it gets pulled in by testcontainers-modules.

Pull Request Checklist

Please confirm the following before requesting review:

  • A human has reviewed every single line of this code before opening the PR (no auto-generated, unreviewed LLM/robot submissions).
  • I have read CONTRIBUTING.md and rebased my branch to produce hygienic commits.

The current version causes flakiness that are especially apparent in the
integration test for dart bindings.

We don't need the `testcontainers` dependency directly since it gets
pulled in by `testcontainers-modules`.
Copy link
Copy Markdown
Collaborator

@benalleng benalleng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tack on 4fdfbfd

@spacebear21 spacebear21 merged commit 1771301 into payjoin:master Aug 18, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants