Fix typo in README#60
Open
jcottom wants to merge 2 commits intopd-rs:mainfrom
Open
Conversation
boozook
requested changes
Aug 11, 2024
Member
There was a problem hiding this comment.
Thanks for the fix. But seems to there is missed import.
That's strange because it's on windows only 🤷🏻♂️.
boozook
approved these changes
Oct 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README mentions a
PLAYDATE_SDKenvironment variable where it should readPLAYDATE_SDK_PATH. This tripped me up when I tried to set up crank and crankstart and I found the original error message cryptic:With this change, it now shows:
which is a little more legible.