-
Notifications
You must be signed in to change notification settings - Fork 497
Update Poppler to 23.12.0 and Fontforge to 20230101 (based on #145) #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@ViliusSutkus89 The latest stable release is poppler-24.01.0.tar.xz... Can you test? |
Contributor
Author
|
@pablgonz , I was already using pdf2htmlEX built against Poppler-24.01.0 , I just forgot to update this PR |
Contributor
|
@ViliusSutkus89 You can take a look at the latest version of |
|
Could anybody solve the compilation error? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I had to add support for current Poppler version ( 23.12.0 ), but I don't feel like maintaining an out-of-tree patch, so I'm sharing it with you's.
This patch is a continuation of #145 by @pablgonz .
Feedback would be much appreciated. Patch is mostly about changing data types, because Poppler added some std::shared_ptr's and std::optional's. Current version also requires C++17 .
Regards,
Vilius