Skip to content

feat: Lock for specific (python, platform, impl) targets#2995

Merged
frostming merged 19 commits into
mainfrom
feat/lock-targets
Jul 8, 2024
Merged

feat: Lock for specific (python, platform, impl) targets#2995
frostming merged 19 commits into
mainfrom
feat/lock-targets

Conversation

@frostming
Copy link
Copy Markdown
Collaborator

Signed-off-by: Frost Ming me@frostming.com

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

frostming added 5 commits July 3, 2024 15:24
Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
…ept a list

Signed-off-by: Frost Ming <me@frostming.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 88.06584% with 87 lines in your changes missing coverage. Please review.

Project coverage is 85.61%. Comparing base (edb2114) to head (8803bf9).
Report is 104 commits behind head on main.

Files with missing lines Patch % Lines
src/pdm/models/repositories/lock.py 84.45% 17 Missing and 13 partials ⚠️
src/pdm/cli/commands/export.py 61.11% 3 Missing and 4 partials ⚠️
src/pdm/cli/actions.py 92.94% 4 Missing and 2 partials ⚠️
src/pdm/models/repositories/pypi.py 83.33% 3 Missing and 3 partials ⚠️
src/pdm/models/specifiers.py 40.00% 4 Missing and 2 partials ⚠️
src/pdm/project/core.py 88.23% 4 Missing and 2 partials ⚠️
src/pdm/cli/utils.py 84.61% 2 Missing and 2 partials ⚠️
src/pdm/models/candidates.py 71.42% 3 Missing and 1 partial ⚠️
src/pdm/models/finder.py 90.69% 3 Missing and 1 partial ⚠️
src/pdm/resolver/providers.py 90.00% 2 Missing and 1 partial ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2995      +/-   ##
==========================================
+ Coverage   85.23%   85.61%   +0.38%     
==========================================
  Files         106      109       +3     
  Lines       10756    10869     +113     
  Branches     2350     2371      +21     
==========================================
+ Hits         9168     9306     +138     
+ Misses       1103     1076      -27     
- Partials      485      487       +2     
Flag Coverage Δ
unittests 85.42% <88.06%> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming
Copy link
Copy Markdown
Collaborator Author

frostming commented Jul 5, 2024

Hi plugin authors:

In this PR, which I would merge shortly, I made some changes to the public(I wish I had made some of them private though) APIs. While I am trying hard to make the change compatible, I am not sure if it would break downstream projects.

If you have time, could you use the changes in this PR to verify your plugin functionality, ensure there are no disruptions, and that you can see deprecation warnings?

Thanks in advance

/cc some of the plugin authors: @macro128 @carstencodes @noirbizarre @sigma67

@sigma67
Copy link
Copy Markdown
Contributor

sigma67 commented Jul 5, 2024

@frostming I am unable today but I will have a look on Sunday

frostming added 10 commits July 5, 2024 18:26
Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
@frostming frostming force-pushed the feat/lock-targets branch from a3e739d to 5f3df0e Compare July 5, 2024 10:27
@macro128
Copy link
Copy Markdown

macro128 commented Jul 5, 2024

Hi! Sure, I'll test my plugin asap and make the changes needed to work with the new lock mechanism

@carstencodes
Copy link
Copy Markdown
Contributor

I am busy this weekend with some weiqi, but I'll check ASAP.

My current feeling is, that

  • pdm-audit plugin won't break: It uses a post install hook (seems unaffected) and calls pdm export under the hood
  • pdm-sbom plugin won't break: It parses the lock file directly and the version does not seem to change
  • pdm-bump plugin won't break: It is not interested in the dependency tree.

@frostming
Copy link
Copy Markdown
Collaborator Author

@carstencodes Thanks for the feedback. I've listed some breaking changes in the news and other removal, they are basically related to dependencies manipulation and resolution results.

I am asking to see if there is any I missed and whether we can make a compatibility layer for them.

frostming added 3 commits July 8, 2024 08:22
Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
@frostming frostming force-pushed the feat/lock-targets branch from bd36e55 to 8803bf9 Compare July 8, 2024 00:55
@frostming frostming merged commit 4b4bfa6 into main Jul 8, 2024
@frostming frostming deleted the feat/lock-targets branch July 8, 2024 02:21
frostming added a commit that referenced this pull request Jul 8, 2024
Signed-off-by: Frost Ming <me@frostming.com>
GabDug added a commit to GabDug/sync-pre-commit-lock that referenced this pull request Aug 1, 2024
GabDug added a commit to GabDug/sync-pre-commit-lock that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dependencies get overriden when there are multiple versions of different markers

4 participants