BUG: Rewrite inspect.unwrap() to respect classes#464
Merged
kernc merged 2 commits intopdoc3:masterfrom Nov 3, 2025
Merged
Conversation
Contributor
Author
|
Hi, @kernc, could you review this PR? |
1 similar comment
Contributor
Author
|
Hi, @kernc, could you review this PR? |
kernc
requested changes
Nov 3, 2025
Fixes pdoc3#463 Post-review changes: * Remove argument `stop` from `pdoc._unwrap_object()` * Fix flake8 errors
USSX-Hares
force-pushed
the
fix/463-inspect-unwrap-rewrite
branch
from
273f8e5 to
3db7827
Compare
Member
|
Lgtm, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #463
Changes
pdoc._unwrap_object()function which behaves likeinsepct.unwrap(), but respects classesinspect.unwrap()in the entire codebasepdoc.test.ApiTest.test_class_wrappersandpdoc.test.example_pkg._test_classwrap)Code Quality
flake8checks passed locally (added a single exception for long lines due to longer docstrings)pdoc.cli#603, but I have not touched this filetoxon the following environments (os: Windows):mypyissues in the code I haven't touched, however