-
-
Notifications
You must be signed in to change notification settings - Fork 67
Add stubs for ISO 4217 and ISO 3166 alpha-2 and alpha-3 #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stubs for ISO 4217 and ISO 3166 alpha-2 and alpha-3 #129
Conversation
…codes from ISO 4217
c0nst4ntin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@julio-cavallari The code looks good (as per usual with your pull requests) 😉 Good work!
Just one idea, though I was having. We are starting to extend the base/chosen preset with a lot of things. Maybe people don't necessarily need/want this. We could think about making these additional things configurable.
Either through a new config value, or by turning the preset option into an array.
@c0nst4ntin I agree, how do you plan on doing this? I think if we don't think it through, the config could start to get very complex. |
|
@julio-cavallari We could change the config to accept: {
"presets": ["base", "laravel", "iso4217", "iso3166"],
// ...
}Or we could always include the base preset and list the other presets like laravel etc. in the config: {
"presets": ["laravel", "iso4217", "iso3166"],
// ...
}What do you think? Maybe we should also get @nunomaduro Feedback on this? |
|
@c0nst4ntin I think it's a good approach But do you think this should be done in this PR? I believe it would be best to separate it into an exclusive PR, so as not to mix two features. About the |
|
@julio-cavallari I think we can first get this added into the project and then change the presets field to an array in the config in another pull request if we see the need! Will hand this to @nunomaduro |
What:
Description:
Some country codes and currency codes are detected as misspelling, so I created these stubs with all country codes in 2 and 3 digit formats, and all currency codes, following ISO standards
Stubs added:
Related:
#123