Skip to content

Conversation

@ffmcgee725
Copy link

  • Update caip-294 to fit extension id as valid target type 👉🏾 caip341

@adonesky1
Copy link

We should also add this property / description to CAIP-282 here

@adonesky1
Copy link

Also the expected type should be modified here on CAIP-295: targetOrigin should be nested in the new target object. And we should make the CAIP to define/establish the origin type as a pending todo

@ffmcgee725 ffmcgee725 requested a review from adonesky1 December 12, 2024 17:22
@jiexi
Copy link

jiexi commented Dec 12, 2024

Do we envision a world in which a wallet supports multiple transports/interfaces. If so, do we think it makes more sense for those to all be defined in one Wallet announcement event, or in several separate wallet announcement events?

Currently I'm thinking that it should be one wallet announcement event, but that doesn't work with the current data structure. In that case perhaps something like this makes more sense again

{
  uuid: '1-1-1-1',
  icon: 'blah',
  name: 'wallet name',
  rdns: 'io.wallet',
  target: {
    caip314: 'abcdefghijklmnop',
    caip315: true,
    caip316: {
      someOtherThing: 'hello'
    }
  }
}

@ffmcgee725 ffmcgee725 requested a review from jiexi December 12, 2024 18:44
@adonesky1
Copy link

Do we envision a world in which a wallet supports multiple transports/interfaces. If so, do we think it makes more sense for those to all be defined in one Wallet announcement event, or in several separate wallet announcement events?

Worth discussing. I would think wallets would generally tend towards supporting one entrypoint/transport for any given context and tell the dapp this is the one to use in this context (platform/browser). Otherwise you're imposing a burden on dapps/libraries to add logic to decide between these options.

But perhaps I'm being short sighted and there are good reasons for offering multiple transport options

@bumblefudge
Copy link

is this ready to go when ChainAgnostic#341 is merged?

pedrouid and others added 2 commits May 12, 2025 12:18
Co-authored-by: jiexi <jiexiluan@gmail.com>
Co-authored-by: jiexi <jiexiluan@gmail.com>
Copy link
Owner

@pedrouid pedrouid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pedrouid pedrouid merged commit 637f455 into pedrouid:browser-wallet-messaging-interface May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants