Skip to content

Comments

Configable Backup Root & No Erazer Rendering#12

Merged
peerdavid merged 3 commits intopeerdavid:masterfrom
cs8898:master
Jun 19, 2020
Merged

Configable Backup Root & No Erazer Rendering#12
peerdavid merged 3 commits intopeerdavid:masterfrom
cs8898:master

Conversation

@cs8898
Copy link
Contributor

@cs8898 cs8898 commented Jun 19, 2020

  • Configable Backup Root

i added a Backup Root to the General Settings so the Backup folder will be based on this configable Root (i keep mine at ~/reMarkable/backups) so i won't need to change it every time

  • Skip Erazer in Drawing

The Erazer gets Drawn as white or in the selected Layer Color
So i also Skip the erazer during rendering (as already done by the erazer_area)

@cs8898
Copy link
Contributor Author

cs8898 commented Jun 19, 2020

Old:

normal_erazer

New:

skipped_erazer

@peerdavid
Copy link
Owner

Hi,

first of all, thank you so much for the improvements, both changes are great! I tested different things and found not a single problem and I therefore merged the pull request. I evaluated the following things:

Test

Backup path config:

  • Start from RemaPy "from scratch (without any config)" and login - OK
  • Create a backup with default path - OK
  • Update config values only of the backup path and ensure that the template path does not change - OK
  • Create a backup with an updated path - OK

Eraser:

  • Text without erase - OK
  • Write text and erase - OK
  • Write text and "area erase" - OK
  • Write text above the erased region - OK
  • Write text above the area erased region - OK
  • Erase in PDF as well as Notebooks with templates - OK

Thanks again,
David

@peerdavid peerdavid merged commit e9af887 into peerdavid:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants