Merged
Conversation
Member
|
Awesome, thanks. I'll review it the next days. |
|
This would be useful for me. Looks like all status checks pass. Did you get time to look at this @jhnns? Happy to help in any way possible 😄 |
jhnns
requested changes
May 27, 2019
Member
jhnns
left a comment
jhnns
left a comment
There was a problem hiding this comment.
There is an error in the typing :)
src/index.d.ts
Outdated
| } | ||
| } | ||
|
|
||
| declare function parseDomain (url: string, customTlds?: RegExp | string[], privateTlds?: boolean): parseDomain.IParsedDomain; |
Member
There was a problem hiding this comment.
customTlds and privateTlds should be part of an ParseOptions object. Take a look at the README :)
Contributor
Author
|
@jhnns I have fixed your review point. please review me again. |
jhnns
approved these changes
May 29, 2019
Member
jhnns
left a comment
jhnns
left a comment
There was a problem hiding this comment.
Thanks ❤️. There's still one mistake (I missed it in the first review as well, sorry), but I'm going to merge this one and fix it on master.
| } | ||
| } | ||
|
|
||
| declare function parseDomain (url: string, options?: parseDomain.IParseOptions): parseDomain.IParsedDomain; |
Member
There was a problem hiding this comment.
parseDomain() returns null when the given URL was not valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer to #31.
I made a Typings file. but I just followed #31 way, though.
I would happy if I can make the first contribution.
Thanks.