Return null if urlSplit is null - fix issues 32 and 61#70
Merged
jhnns merged 1 commit intopeerigon:masterfrom May 28, 2019
Merged
Return null if urlSplit is null - fix issues 32 and 61#70jhnns merged 1 commit intopeerigon:masterfrom
jhnns merged 1 commit intopeerigon:masterfrom
Conversation
Member
|
Thank you for your PR and for adding tests ❤️. This has already been addressed with #63 |
Contributor
Author
|
@jhnns The changes in #63 will not cover the case of these character being present with other valid charcter. e.g., https://www.hell\no.com. \n charater present in url will cause the same error. |
Member
|
You're right, sorry. It was too late yesterday :) |
Member
|
Published with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.