Skip to content

Use file's created time to print build error message#74

Merged
jhnns merged 1 commit intopeerigon:remove-updated-atfrom
fadedimon:fix/file-created-time
Jun 14, 2019
Merged

Use file's created time to print build error message#74
jhnns merged 1 commit intopeerigon:remove-updated-atfrom
fadedimon:fix/file-created-time

Conversation

@fadedimon
Copy link

@fadedimon fadedimon commented Jun 7, 2019

updatedAt property in builded lists breaks bundle caching and messing up with "identical build checks"

This PR implements @jhnns solution to use created file time

Based on this issue: #60

@fadedimon fadedimon changed the title fix: Switched to created-file time in build error message Use file's created time to print build error message Jun 7, 2019
@jhnns jhnns changed the base branch from master to remove-updated-at June 14, 2019 16:38
@jhnns jhnns merged commit 23ca419 into peerigon:remove-updated-at Jun 14, 2019
@jhnns
Copy link
Member

jhnns commented Jun 14, 2019

We can't use the birthdate because that will be the date when npm install has been executed. We just need to save the date in separate file. I'm going to implement that :)

Anyway, thanks 👍

@fadedimon fadedimon deleted the fix/file-created-time branch June 14, 2019 16:39
@jhnns
Copy link
Member

jhnns commented Jun 14, 2019

Follow up #75

@fadedimon
Copy link
Author

fadedimon commented Jun 14, 2019

@jhnns Since separate file contains data based on it's generated time, problem is still here: we still have not matching files at every build :)

Maybe we can use last-modified time and not created-time?

@jhnns
Copy link
Member

jhnns commented Jun 17, 2019

Since separate file contains data based on it's generated time, problem is still here: we still have not matching files at every build :)

I don't get the problem :). The meta.json is not included in a bundle because it is not imported/required anywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants