Skip to content

fix stable sorting on node 11.6.0 #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
missinglink merged 1 commit into from
Jan 14, 2019
Merged

fix stable sorting on node 11.6.0 #1253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions middleware/sortResponseData.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
const _ = require('lodash');
const stable = require('stable');

const logger = require('pelias-logger').get('api');

Expand All @@ -12,8 +13,8 @@ function setup(comparator, should_execute) {
// capture the pre-sort order
const presort_order = res.data.map(_.property('_id'));

// sort operates on array in place
res.data.sort(comparator(req.clean));
// stable operates on array in place
stable.inplace(res.data, comparator(req.clean));

// capture the post-sort order
const postsort_order = res.data.map(_.property('_id'));
Expand Down