Skip to content

Conversation

@notAreYouScared
Copy link
Member

@notAreYouScared notAreYouScared commented Dec 21, 2025

Backup the plugins folder, also tell the user to run the permission commands...

Summary by CodeRabbit

  • Bug Fixes

    • Update process now preserves plugin data and backup files to prevent data loss.
  • New Features

    • Added post-update guidance reminding administrators to reapply storage permissions and ownership after an update.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 21, 2025

Walkthrough

Modifies static/updatePanel.sh to exclude backup and plugins directories (and panel.tar.gz) from cleanup and to print post-update permission/ownership commands for manual re-application.

Changes

Cohort / File(s) Summary
Update script changes
static/updatePanel.sh
Adjusts cleanup logic to preserve backup and plugins directories and panel.tar.gz; adds echo'd reminders showing commands to reapply storage permissions and ownership after update.

Sequence Diagram(s)

(no diagram — changes are a small script update, not a multi-component control-flow change)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify the cleanup exclusion patterns correctly match intended paths
  • Confirm echo'd permission/ownership commands are accurate for target environment

Poem

🐰 I hopped through scripts with gentle cheer,
Saved plugins and backups safe and near,
After the update, a whispered guide,
"Reset the perms," said the bunny with pride,
A tidy patch, and carrot confetti here. 🎉

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title 'Update script to support plugins' is directly related to the main changes: excluding the 'plugins' directory from cleanup and adding post-update instructions.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch charles/update-script

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@netlify
Copy link

netlify bot commented Dec 21, 2025

Deploy Preview for pelica ready!

Name Link
🔨 Latest commit 39233c7
🔍 Latest deploy log https://app.netlify.com/projects/pelica/deploys/69481fff4ca3e600086978d4
😎 Deploy Preview https://deploy-preview-181--pelica.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
static/updatePanel.sh (1)

220-222: Consider: Reminder message is redundant with earlier error handling.

Lines 207-215 already print these exact commands when chmod or chown fail. The additional reminder at the end duplicates this output when failures occur. If the concern is about "silent failures," consider enhancing the error detection on lines 206 and 212 rather than adding a blanket reminder.

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7242964 and da9c8db.

📒 Files selected for processing (1)
  • static/updatePanel.sh (4 hunks)

@notAreYouScared notAreYouScared changed the title Update install script to support plugins Update script to support plugins Dec 23, 2025
@notAreYouScared notAreYouScared merged commit 019f49e into main Dec 23, 2025
5 checks passed
@notAreYouScared notAreYouScared deleted the charles/update-script branch December 23, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants