-
-
Notifications
You must be signed in to change notification settings - Fork 254
Refactor Node Stats #1145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Node Stats #1145
Conversation
They have been problematic from day one... no need to make them a scheduled job
|
I agree that it's not a great solution, but we can't poll every single second either, that's even worse. |
How is 1 second worse than a webhook doing it every second? This isn't a job that runs and only runs on page view. |
/**
* Get the middleware the job should pass through.
*
* @return array<int, object>
*/
public function middleware(): array
{
return [(new WithoutOverlapping($this->order->id))->dontRelease()];
} |
|
I still feel we should poll when they're viewing the page.... What's the point of being able to view the last 30 or whatever seconds before you view the page? |
They've been problematic from day one... no need to make them a scheduled job