Refactor Providers to be a singleton
#1327
Conversation
There was a problem hiding this comment.
Is this necessary as a provider? I don't think the majority of people are going to add anymore custom providers or if it's worth supporting them.
There was a problem hiding this comment.
I think the Provider makes sense here since it configures the AvatarService. We could hardcode those 2 schemas as the only options the service supports, but that seems like it makes it less modular.
There was a problem hiding this comment.
Is this necessary as a provider? I don't think the majority of people are going to add anymore custom providers or if it's worth supporting them.
There was a problem hiding this comment.
Same as the AvatarService Provider.
| /** | ||
| * @return array<string, string|string[]|bool|null> | ||
| */ | ||
| public function getServiceConfig(): array; |
There was a problem hiding this comment.
Can we refactor this to be either a not complex array (string[] only) or a dto?
There was a problem hiding this comment.
Socialite wants different configs for different providers (Steam wants different configs than Gitlab).
Do you have any suggestions? Not sure how to make a DTO that's not just a bag of dynamic props.
Uh oh!
There was an error while loading. Please reload this page.