Skip to content

Conversation

@JoanFo1456
Copy link
Contributor

After repairing some issues i had with my git, i suppose now is ready to work. (Did a pr before)
Some files probably have disappeared on another ones with the new changes recently, same some files probably need to be on another part, after all, this was a update following main but some files weren't removed at all...
I will make changes on it, making it less "draft" if this is accepted, only change that needs to be done at least i think is when saving to reload filament with the new changes.

@JoanFo1456
Copy link
Contributor Author

image
Lance asked for a preview, this is an example i made, i'm only using the embed editor, but also works with messages only, variables on the payload can be used on the preview and discord.
When a variable like name doesn't exist on the view, it uses Faker to show a name.

@JoanFo1456 JoanFo1456 force-pushed the feature/DiscordWebhook branch from f28cb83 to 3286514 Compare May 9, 2025 19:12
Copy link
Member

@lancepioch lancepioch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hard work so far, keep it up!

@Boy132 Boy132 linked an issue May 12, 2025 that may be closed by this pull request
@JoanFo1456
Copy link
Contributor Author

Lance, if you get the chance let me know if everything is good or not, my suggestion here is adding once again faker to show example values on the embed, instead of giving the values directly.

@JoanFo1456 JoanFo1456 requested a review from lancepioch May 13, 2025 21:38
@pelican-dev pelican-dev deleted a comment from JoanFo1456 May 14, 2025
@JoanFo1456
Copy link
Contributor Author

I have used a phpstan ignore next line on DiscordPreview, since i didn't quite found a way, i'm open to suggestions...

@JoanFo1456 JoanFo1456 requested a review from lancepioch May 15, 2025 21:13
@JoanFo1456
Copy link
Contributor Author

Now you can take a look and everything...

JoanFo1456 and others added 3 commits May 27, 2025 19:54
Did Lance's suggestion.

Co-authored-by: Lance Pioch <lancepioch@gmail.com>
@JoanFo1456 JoanFo1456 requested a review from lancepioch May 27, 2025 18:10
@JoanFo1456
Copy link
Contributor Author

Everything seems good to be merged, so if you guys want, go ahead.

@JoanFo1456 JoanFo1456 requested a review from Boy132 June 10, 2025 14:02
@JoanFo1456
Copy link
Contributor Author

You guys think is good enough to be on the panel? Or should I make some other changes

@rmartinoscar rmartinoscar marked this pull request as draft June 17, 2025 23:49
@JoanFo1456 JoanFo1456 marked this pull request as ready for review June 26, 2025 00:36
@notAreYouScared notAreYouScared merged commit c5aa8a3 into pelican-dev:main Jul 5, 2025
25 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2025
@JoanFo1456 JoanFo1456 deleted the feature/DiscordWebhook branch September 29, 2025 18:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Webhooks in discord format

5 participants