-
-
Notifications
You must be signed in to change notification settings - Fork 254
DiscordWebhooks #1355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DiscordWebhooks #1355
Conversation
f28cb83 to
3286514
Compare
lancepioch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the hard work so far, keep it up!
app/Filament/Admin/Resources/WebhookResource/Pages/EditWebhookConfiguration.php
Outdated
Show resolved
Hide resolved
app/Filament/Admin/Resources/WebhookResource/Pages/CreateWebhookConfiguration.php
Outdated
Show resolved
Hide resolved
Removed easterEgg function Co-authored-by: Lance Pioch <lancepioch@gmail.com>
|
Lance, if you get the chance let me know if everything is good or not, my suggestion here is adding once again faker to show example values on the embed, instead of giving the values directly. |
app/Filament/Admin/Resources/WebhookResource/Pages/EditWebhookConfiguration.php
Outdated
Show resolved
Hide resolved
resources/views/filament/admin/widgets/discord-preview.blade.php
Outdated
Show resolved
Hide resolved
resources/views/filament/admin/widgets/discord-preview.blade.php
Outdated
Show resolved
Hide resolved
resources/views/filament/admin/widgets/discord-preview.blade.php
Outdated
Show resolved
Hide resolved
resources/views/filament/admin/widgets/discord-preview.blade.php
Outdated
Show resolved
Hide resolved
|
I have used a phpstan ignore next line on DiscordPreview, since i didn't quite found a way, i'm open to suggestions... |
|
Now you can take a look and everything... |
Did Lance's suggestion. Co-authored-by: Lance Pioch <lancepioch@gmail.com>
|
Everything seems good to be merged, so if you guys want, go ahead. |
app/Filament/Admin/Resources/WebhookResource/Pages/EditWebhookConfiguration.php
Outdated
Show resolved
Hide resolved
database/migrations/2025_04_09_015500_add_webhook_configurations_type_column.php
Outdated
Show resolved
Hide resolved
|
You guys think is good enough to be on the panel? Or should I make some other changes |

After repairing some issues i had with my git, i suppose now is ready to work. (Did a pr before)
Some files probably have disappeared on another ones with the new changes recently, same some files probably need to be on another part, after all, this was a update following main but some files weren't removed at all...
I will make changes on it, making it less "draft" if this is accepted, only change that needs to be done at least i think is when saving to reload filament with the new changes.