Fix missing font #1404
Merged
Fix missing font #1404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When loading the page on monospace, will say that monospace.ttf is missing, this fixes it.
rmartinoscar
requested changes
May 25, 2025
Member
There was a problem hiding this comment.
I can't use gh thing cause you are not allowed to comment on lines that weren't edited in this PR
Placeholder::make('font_preview')
->label(trans('profile.font_preview'))
->columnSpan(2)
->content(function (Get $get) {
$fontName = $get('console_font') ?? 'monospace';
$fontSize = $get('console_font_size') . 'px';
$style = <<<CSS
.preview-text {
font-family: $fontName;
font-size: $fontSize;
margin-top: 10px;
display: block;
}
CSS;
if ($fontName !== 'monospace') {
$fontUrl = asset("storage/fonts/$fontName.ttf");
$style = <<<CSS
@font-face {
font-family: $fontName;
src: url("$fontUrl");
}
$style
CSS;
}
return new HtmlString(<<<HTML
<style>
$style
</style>
<span class="preview-text">The quick blue pelican jumps over the lazy pterodactyl. :)</span>
HTML);
}),
Contributor
Author
|
We thought of that, but was sketchy for us, that's why it is this way, but sure I'll change it. |
rmartinoscar
requested changes
May 25, 2025
lancepioch
approved these changes
Jun 7, 2025
Contributor
Author
|
Everything seems good to be merged, so if you guys want, go ahead. |
rmartinoscar
force-pushed
the
FixMissingFont
branch
from
2e0f9e2 to
ac157ac
Compare
rmartinoscar
approved these changes
Jun 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With mristau we repaired that on browser console when loading EditProfile or server console would show that monospace.ttf doesn't exist.