Skip to content

Conversation

@Boy132
Copy link
Member

@Boy132 Boy132 commented Jun 3, 2025

Followup fix for #1423

@Boy132 Boy132 self-assigned this Jun 3, 2025
@Boy132 Boy132 requested a review from Copilot June 3, 2025 13:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ensures that when a node is not behind a proxy, its daemon_listen setting is automatically set to match daemon_connect.

  • Adds a data mutation hook in the EditNode page to sync these fields before saving.
  • Adds a similar mutation hook in the CreateNode page before creating the record.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
app/Filament/Admin/Resources/NodeResource/Pages/EditNode.php Introduces mutateFormDataBeforeSafe to overwrite daemon_listen when behind_proxy is false.
app/Filament/Admin/Resources/NodeResource/Pages/CreateNode.php Adds mutateFormDataBeforeCreate with the same sync logic.
Comments suppressed due to low confidence (1)

app/Filament/Admin/Resources/NodeResource/Pages/EditNode.php:645

  • This new branch for behind_proxy isn’t covered by existing tests. Add unit or integration tests to verify that daemon_listen is correctly set when behind_proxy is false.
if (!$data['behind_proxy']) {

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Boy132 Boy132 merged commit 456c4f4 into main Jun 4, 2025
25 checks passed
@Boy132 Boy132 deleted the boy132/wings-ports-part-two branch June 4, 2025 06:37
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants