Skip to content

Replace $allocation->toString() with $allocation->address #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rmartinoscar merged 1 commit into from
Jun 4, 2025
Merged

Replace $allocation->toString() with $allocation->address #1431

rmartinoscar merged 1 commit into from
Jun 4, 2025

Conversation

@rmartinoscar
Copy link
Member

@rmartinoscar rmartinoscar commented Jun 4, 2025

address is already a string

panel/app/Models/Allocation.php

Line 26 in 0ba497a

* @property string $address

@rmartinoscar rmartinoscar requested review from Boy132 and lancepioch June 4, 2025 03:08
@rmartinoscar rmartinoscar self-assigned this Jun 4, 2025
@rmartinoscar rmartinoscar force-pushed the chore/removeUselessFunction branch from 2026fe9 to eb324eb Compare June 4, 2025 03:16
@rmartinoscar rmartinoscar merged commit e7a950f into main Jun 4, 2025
25 checks passed
@rmartinoscar rmartinoscar deleted the chore/removeUselessFunction branch June 4, 2025 20:14
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Boy132 Boy132 Boy132 approved these changes

@lancepioch lancepioch Awaiting requested review from lancepioch

Assignees

@rmartinoscar rmartinoscar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rmartinoscar @Boy132