Skip to content

Conversation

@JoanFo1456
Copy link
Contributor

With Quinten's wings branch should allow allocationless servers.

@JoanFo1456
Copy link
Contributor Author

It's missing Grid view, once i have it controlled i will also push with lint.

@JoanFo1456
Copy link
Contributor Author

On my environment is not failing Lint, idk why here is failing.
image

@rmartinoscar rmartinoscar marked this pull request as draft June 5, 2025 05:11
Boy132
Boy132 previously requested changes Jun 5, 2025
@QuintenQVD0
Copy link
Contributor

I know there are some problems with the panel database and things been null / 0.
The only thing I need to be certain is that wings out of the server struct needs to receive 127.0.0.1 and port 0 from the panel this is because port 0 is invalid and wings will skip it and so returning an allocationless server. But we agreed that address should be 127.0.0.1 because the file parser would else return nothing for server.allocations.default.ip where it should return 127.0.0.1 and server.allocations.default.port must return 0, what the UI shows is not my part but I do feel that 127.0.0.1 is more right then None in some places like the server overview / list

@JoanFo1456
Copy link
Contributor Author

JoanFo1456 commented Jun 5, 2025

So what I do, should I change it all to None or let it be 127.0.0.1:0, Boy132

@JoanFo1456 JoanFo1456 force-pushed the feature/server-without-allocations branch from c7fece1 to ec57829 Compare June 6, 2025 16:19
@rmartinoscar rmartinoscar linked an issue Jun 11, 2025 that may be closed by this pull request
@rmartinoscar rmartinoscar marked this pull request as ready for review June 21, 2025 20:14
@JoanFo1456 JoanFo1456 requested a review from Boy132 June 21, 2025 20:19
@rmartinoscar rmartinoscar requested a review from lancepioch June 24, 2025 11:05
Copy link
Member

@notAreYouScared notAreYouScared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you dissociate an allocation on the admin side, the existing note is not cleared.

…ocations, added allocation notes on admin side.
@JoanFo1456
Copy link
Contributor Author

JoanFo1456 commented Jun 25, 2025

Not again... Why pint

@lancepioch lancepioch merged commit dca37cc into pelican-dev:main Jun 25, 2025
25 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2025
@JoanFo1456 JoanFo1456 deleted the feature/server-without-allocations branch June 26, 2025 00:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Servers without allocations

6 participants