Skip to content

Conversation

@wbvanderbroek
Copy link
Contributor

Previously creating a server through the api on a specific node wouldn't work with something like this in the payload:

"deploy" => [
"dedicated_ip" => false,
"tags" => ["yournodetag"],
"port_range" => []
],
Because the tag would be completely erased by the validator. And would only be stored in the deployment variable.
This will fix that by using the deployment variable instead of the data variable

@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@wbvanderbroek
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

I have read the CLA Document and I hereby sign the CLA

@wbvanderbroek
Copy link
Contributor Author

recheck

@wbvanderbroek
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@wbvanderbroek
Copy link
Contributor Author

recheck

@wbvanderbroek
Copy link
Contributor Author

wbvanderbroek commented Jun 22, 2025

I just noticed some more strange behaviour with creating servers through the api. When NOT using the deployment it will use the first allocation available, but when you do use the deployment it simply gets a random allocation that is available instead.

I guess this is fine though since the allocation specified will then place it in the correct node but it does feel a bit off.

@lancepioch
Copy link
Member

Thank you!

@lancepioch lancepioch merged commit 7731f16 into pelican-dev:main Jun 25, 2025
25 of 26 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants