Skip to content

Conversation

@Boy132
Copy link
Member

@Boy132 Boy132 commented Jul 3, 2025

Closes #1201
Also fixes activity log for deleting api keys.

grafik
Yes, the fingerprint is overflowing and there is this weird gap. That's because of the (non-exsiting) label and I don't know to fix it. :(

@Boy132 Boy132 self-assigned this Jul 3, 2025
@rmartinoscar
Copy link
Member

rmartinoscar commented Jul 3, 2025

I feel like SSHKeyController, StoreSSHKeyRequest & tests should be refactored to use the new service, other then type casting looks good i'll give it a try when home.

@notAreYouScared notAreYouScared requested a review from Copilot July 6, 2025 20:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for managing SSH keys in the user profile and refines API key deletion logic.

  • Introduces new translation strings for SSH keys alongside existing API keys.
  • Implements KeyCreationService to validate and store SSH public keys.
  • Updates the Filament profile page to handle SSH key creation/deletion and improves API key delete handling.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
lang/en/profile.php Added translation entries for API and SSH key operations.
app/Services/Ssh/KeyCreationService.php New service to validate public keys, enforce algorithms, and persist SSH keys.
app/Filament/Pages/Auth/EditProfile.php Updated API key UI for deletion logging; added SSH key management tab.
Comments suppressed due to low confidence (1)

app/Services/Ssh/KeyCreationService.php:18

  • Consider adding unit tests for the new KeyCreationService.handle method to cover valid key creation, invalid key input, unsupported DSA keys, and duplicate key scenarios.
    public function handle(User $user, string $name, string $publicKey): UserSSHKey

@Boy132 Boy132 merged commit 556551b into main Jul 6, 2025
25 checks passed
@Boy132 Boy132 deleted the boy132/ssh-keys-ui branch July 6, 2025 20:51
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-Add SSH Keys for SFTP Auth

4 participants