-
-
Notifications
You must be signed in to change notification settings - Fork 254
Add SSH Keys to Profile #1478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SSH Keys to Profile #1478
Conversation
|
I feel like SSHKeyController, StoreSSHKeyRequest & tests should be refactored to use the new service, other then type casting looks good i'll give it a try when home. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds support for managing SSH keys in the user profile and refines API key deletion logic.
- Introduces new translation strings for SSH keys alongside existing API keys.
- Implements
KeyCreationServiceto validate and store SSH public keys. - Updates the Filament profile page to handle SSH key creation/deletion and improves API key delete handling.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| lang/en/profile.php | Added translation entries for API and SSH key operations. |
| app/Services/Ssh/KeyCreationService.php | New service to validate public keys, enforce algorithms, and persist SSH keys. |
| app/Filament/Pages/Auth/EditProfile.php | Updated API key UI for deletion logging; added SSH key management tab. |
Comments suppressed due to low confidence (1)
app/Services/Ssh/KeyCreationService.php:18
- Consider adding unit tests for the new KeyCreationService.handle method to cover valid key creation, invalid key input, unsupported DSA keys, and duplicate key scenarios.
public function handle(User $user, string $name, string $publicKey): UserSSHKey
Closes #1201
Also fixes activity log for deleting api keys.
Yes, the fingerprint is overflowing and there is this weird gap. That's because of the (non-exsiting) label and I don't know to fix it. :(