Filter out already used ips with the same port #1496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boy132
approved these changes
Jul 8, 2025
|
Related to this? #1508 |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the IP selection dropdown in the Allocations relation manager to exclude IPs already used by allocations on the same port, while still including the current allocation’s IP.
- Exclude IPs that are already allocated to the same port
- Prepend the current allocation’s IP and enforce uniqueness
- Convert the resulting collection to an array for options
Comments suppressed due to low confidence (1)
app/Filament/Admin/Resources/NodeResource/RelationManagers/AllocationsRelationManager.php:65
- The new filtering logic should be covered by unit or feature tests to ensure that IPs are correctly excluded or included based on port and current allocation.
->options(fn (Allocation $allocation) => collect($this->getOwnerRecord()->ipAddresses())
app/Filament/Admin/Resources/NodeResource/RelationManagers/AllocationsRelationManager.php
Outdated
Show resolved
Hide resolved
app/Filament/Admin/Resources/NodeResource/RelationManagers/AllocationsRelationManager.php
Outdated
Show resolved
Hide resolved
Boy132
approved these changes
Jul 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1495