Skip to content

Conversation

@Boy132
Copy link
Member

@Boy132 Boy132 commented Aug 15, 2025

Add the oauth name as parameter to the translation and remove the invisible space at the end of the translation string.

@Boy132 Boy132 self-assigned this Aug 15, 2025
@coderabbitai
Copy link

coderabbitai bot commented Aug 15, 2025

📝 Walkthrough

Walkthrough

Updated OAuth action label construction in EditProfile to use translation placeholders. Adjusted English translations for profile link/unlink to include :name. No other logic or signatures changed.

Changes

Cohort / File(s) Change Summary
EditProfile OAuth label i18n
app/Filament/Pages/Auth/EditProfile.php
Replaced string concatenation with trans('profile.{link
English profile translations
lang/en/profile.php
Updated keys: link → "Link :name", unlink → "Unlink :name".

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
app/Filament/Pages/Auth/EditProfile.php (1)

177-177: Optional: Add a backward-compatible fallback for locales not yet updated

If some locales haven’t added ':name' yet, the name will disappear from the label in those languages. You can add a small fallback that appends the name when the translation doesn’t change after passing parameters.

Apply this diff:

-                                                ->label(trans('profile.' . ($unlink ? 'unlink' : 'link'), ['name' => $name]))
+                                                ->label(function () use ($unlink, $name) {
+                                                    $key = 'profile.' . ($unlink ? 'unlink' : 'link');
+                                                    $withName = trans($key, ['name' => $name]);
+                                                    $withoutName = trans($key);
+                                                    // If the translation didn't change with the parameter, the locale likely lacks the ':name' placeholder.
+                                                    return $withName === $withoutName
+                                                        ? trim($withoutName . ' ' . $name)
+                                                        : $withName;
+                                                })
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between c77a37e and b91b05f.

📒 Files selected for processing (2)
  • app/Filament/Pages/Auth/EditProfile.php (1 hunks)
  • lang/en/profile.php (1 hunks)
🔇 Additional comments (3)
lang/en/profile.php (1)

24-25: Placeholders added and trailing space removed — looks good

Switching to a named placeholder improves i18n flexibility and eliminates the invisible trailing space issue.

app/Filament/Pages/Auth/EditProfile.php (2)

177-177: Using a translation key with a placeholder is the right direction

This makes the label fully localizable and removes string concatenation in code.


171-181: Sanity check: provider name safety

$schema->getName() is used in labels and notifications. Ensure provider names are trusted constants (not user-supplied) to avoid any chance of HTML injection in rendered labels/notifications. Filament typically escapes labels, but validating the data source keeps things robust.

@Boy132 Boy132 merged commit b5ebd54 into main Aug 15, 2025
25 checks passed
@Boy132 Boy132 deleted the boy132/fix-unlink-translation branch August 15, 2025 12:06
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants