-
-
Notifications
You must be signed in to change notification settings - Fork 254
fix php ini permissions #1619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix php ini permissions #1619
Conversation
Changes the owner of php config to www-data
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... 📒 Files selected for processing (2)
Tip CodeRabbit can scan for known vulnerabilities in your dependencies using OSV Scanner.OSV Scanner will automatically detect and report security vulnerabilities in your project's dependencies. No additional configuration is required. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🧹 Nitpick comments (2)
Dockerfile.dev (1)
93-93: Chown syntax consistencyMinor: elsewhere you use explicit user:group (www-data:www-data). For consistency and clarity across environments, prefer the explicit form over relying on implicit primary group resolution.
If you keep this ownership change, consider:
- && chown -R www-data: /usr/local/etc/php/ + && chown -R www-data:www-data /usr/local/etc/php/Dockerfile (1)
89-89: Explicit group for chownNit: use user:group explicitly for consistency.
- && chown -R www-data: /usr/local/etc/php/ + && chown -R www-data:www-data /usr/local/etc/php/
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
Dockerfile(1 hunks)Dockerfile.dev(1 hunks)
Changes the owner of php config to www-data