-
-
Notifications
You must be signed in to change notification settings - Fork 254
Fix 500 for closeable alert banners #1620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThe alert banner Blade view updates its close action binding to call remove with the ID from getId() instead of getID(). No other markup or logic changes. Changes
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
resources/views/livewire/alerts/alert-banner.blade.php (1)
23-23: Prefer @js() to safely encode the argument for LivewireIf the ID ever contains quotes or special characters, the current quoting can break the JS expression. Using
@js()(orJs::from(...)) JSON-encodes the value safely.Apply this diff:
- <x-filament::icon-button color="gray" icon="tabler-x" wire:click="remove('{{$getId()}}')" /> + <x-filament::icon-button color="gray" icon="tabler-x" wire:click="remove(@js($getId()))" />Alternative (if you prefer a helper):
wire:click="remove({{ \Illuminate\Support\Js::from($getId()) }})".
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
resources/views/livewire/alerts/alert-banner.blade.php(1 hunks)
🔇 Additional comments (1)
resources/views/livewire/alerts/alert-banner.blade.php (1)
23-23: LGTM: Correct method call fixes the 500Switching to
getId()aligns with the surrounding API (e.g.,getIcon,getTitle) and should resolve the undefined-call 500. Looks good.
Small typo...