Filament v4 🎉 #1651
Filament v4 🎉 #1651
Conversation
tabs do not render on spa currently
deprecated
deprecated
app/Models/User.php
Outdated
| /** @return array<mixed> */ | ||
| public function getCustomization(): array | ||
| { | ||
| return json_decode($this->customization, true) ?? []; |
There was a problem hiding this comment.
Shouldn't customization be a an array cast so you don't need json_decode?
There was a problem hiding this comment.
Yes and even better you should be able to specify the key as a function arg, if there's none you return the full array otherwise you return the value of that key so we don't have getCustomization()['key'] but getCustomization('key')
There was a problem hiding this comment.
It throws an App\Models\User::getCustomization(): Return value must be of type array, string returned when not using json_decode for some reason.
|
|
||
| class TwoFactorListener | ||
| { | ||
| // TODO: add event to filament |
There was a problem hiding this comment.
Yes-ish. If the event isn't called there is no activity logged.
Co-authored-by: Lance Pioch <git@lance.sh>
There was a problem hiding this comment.
Pull Request Overview
This pull request upgrades the application from Filament v3 to Filament v4, bringing significant changes to the panel framework. The upgrade includes architectural changes such as replacing Forms with Schemas, updating authentication methods, and modernizing the codebase structure.
- Upgraded core Filament framework from v3.3 to v4.0 with breaking API changes
- Replaced authentication system with new multi-factor authentication using app-based TOTP and email
- Updated form architecture from Forms to Schemas throughout the application
Reviewed Changes
Copilot reviewed 298 out of 379 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| composer.json | Updated Filament version constraint and removed incompatible packages |
| database/migrations/ | Added new MFA fields migration replacing TOTP system |
| app/Models/User.php | Implemented new MFA interfaces and removed legacy TOTP fields |
| app/Livewire/Installer/ | Updated installer components to use new Schema-based forms |
| app/Providers/Filament/ | Updated panel providers for v4 authentication methods |
| app/Http/Middleware/ | Removed legacy 2FA middleware in favor of built-in MFA |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Well... This should be fun ❤️