Fix finish & add translation for Installer title #1659

rmartinoscar · 2025-09-04T19:15:05Z

No description provided.

coderabbitai · 2025-09-04T19:15:11Z

📝 Walkthrough

Walkthrough

Adds a public getTitle() method and changes wizard nextAction in PanelInstaller to an explicit closure with a translated label and preserved Enter keybinding; fixes finish button translation rendering. Replaces hard-coded submit labels with translation calls in two Filament pages and adds corresponding translation keys for installer, admin node, and admin server.

Changes

Cohort / File(s)	Summary
Installer component updates `app/Livewire/Installer/PanelInstaller.php`	Added `public function getTitle(): string`; reworked wizard `nextAction` to an explicit closure that sets label via `trans('installer.next_step')` while preserving `keyBindings('enter')`; changed finish button to render translation via Blade echo.
Installer translations `lang/en/installer.php`	Added top-level keys `'title' => 'Panel Installer'` and `'next_step' => 'Next Step'`.
Filament create page label changes `app/Filament/Admin/Resources/NodeResource/Pages/CreateNode.php`, `app/Filament/Admin/Resources/ServerResource/Pages/CreateServer.php`	Replaced hard-coded submit button labels with translation calls `{{ trans('admin/node.create') }}` and `{{ trans('admin/server.create') }}` respectively.
Admin translations (create labels) `lang/en/admin/node.php`, `lang/en/admin/server.php`	Added `'create' => 'Create Node'` to `admin/node.php` and `'create' => 'Create Server'` to `admin/server.php`.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant PanelInstaller
  participant WizardUI
  participant Translator

  User->>PanelInstaller: Open installer
  PanelInstaller->>Translator: trans('installer.title')
  Translator-->>PanelInstaller: "Panel Installer"
  PanelInstaller->>WizardUI: configure nextAction (closure)<br/>label = trans('installer.next_step'), keyBindings('enter')
  WizardUI->>Translator: trans('installer.next_step')
  Translator-->>WizardUI: "Next Step"

  User->>WizardUI: Click Finish / Enter
  WizardUI->>Translator: trans('installer.finish') via Blade echo
  Translator-->>WizardUI: "Finish"
  WizardUI-->>User: Render translated labels

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

Visit our Status Page to check the current availability of CodeRabbit.
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (3)

lang/en/installer.php (1)

101-103: Ensure installer.next_step in all locale files
Only lang/en/installer.php defines both title and next_step. Create or update lang//installer.php for each supported locale to include these keys and avoid English fallbacks.
app/Livewire/Installer/PanelInstaller.php (2)
49-52: Localized page title — LGTM (optional: widen return type)

Matches project pattern. If you ever need rich titles, consider returning string|Htmlable.

Apply if desired:
+use Illuminate\Contracts\Support\Htmlable;
@@
-    public function getTitle(): string
+    public function getTitle(): string|Htmlable
     {
         return trans('installer.title');
     }
87-91: Use array form for keyBindings in PanelInstaller
Change
->keyBindings('enter')
to
->keyBindings(['enter'])
to match the array usage elsewhere (e.g. Settings.php uses ->keyBindings(['mod+s'])).

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

MCP integration is disabled by default for public repositories
Jira integration is disabled by default for public repositories
Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 6671d45 and df8c499.

📒 Files selected for processing (2)

app/Livewire/Installer/PanelInstaller.php (2 hunks)
lang/en/installer.php (2 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

app/Livewire/Installer/PanelInstaller.php (7)

app/Filament/Admin/Pages/Health.php (1)

getTitle (25-28)

app/Filament/Admin/Pages/Settings.php (1)

getTitle (87-90)

app/Filament/Server/Pages/Settings.php (1)

getTitle (304-307)

app/Filament/Server/Resources/FileResource/Pages/SearchFiles.php (1)

getTitle (77-80)

app/Filament/Server/Resources/UserResource/Pages/ListUsers.php (1)

getTitle (167-170)

app/Filament/Server/Resources/FileResource/Pages/ListFiles.php (1)

getTitle (610-613)

app/Filament/Server/Resources/DatabaseResource/Pages/ListDatabases.php (1)

getTitle (80-83)

🔇 Additional comments (2)

lang/en/installer.php (1)

4-4: Title translation key added — LGTM

Key path installer.title matches usage in PanelInstaller. No issues.

app/Livewire/Installer/PanelInstaller.php (1)

98-98: Finish label translation fixed — LGTM

Using Blade-rendered {{ trans('installer.finish') }} is correct and safe.

app/Livewire/Installer/PanelInstaller.php

coderabbitai

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

MCP integration is disabled by default for public repositories
Jira integration is disabled by default for public repositories
Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between df8c499 and fc66d22.

📒 Files selected for processing (4)

app/Filament/Admin/Resources/NodeResource/Pages/CreateNode.php (1 hunks)
app/Filament/Admin/Resources/ServerResource/Pages/CreateServer.php (1 hunks)
lang/en/admin/node.php (1 hunks)
lang/en/admin/server.php (1 hunks)

✅ Files skipped from review due to trivial changes (1)

lang/en/admin/server.php

🔇 Additional comments (1)

app/Filament/Admin/Resources/NodeResource/Pages/CreateNode.php (1)

403-409: Submit button now uses translation key: LGTM

{{ trans('admin/node.create') }} matches the new lang entry and keeps UI consistent.

app/Filament/Admin/Resources/ServerResource/Pages/CreateServer.php

lang/en/admin/node.php

Fix finish & add translation for Installer title

df8c499

rmartinoscar requested review from Boy132 and notAreYouScared September 4, 2025 19:15

rmartinoscar self-assigned this Sep 4, 2025

coderabbitai bot reviewed Sep 4, 2025

View reviewed changes

Boy132 reviewed Sep 4, 2025

View reviewed changes

app/Livewire/Installer/PanelInstaller.php Show resolved Hide resolved

Boy132 approved these changes Sep 4, 2025

View reviewed changes

Fix missing submitAction translations

fc66d22

coderabbitai bot reviewed Sep 4, 2025

View reviewed changes

app/Filament/Admin/Resources/ServerResource/Pages/CreateServer.php Show resolved Hide resolved

lang/en/admin/node.php Show resolved Hide resolved

notAreYouScared approved these changes Sep 4, 2025

View reviewed changes

rmartinoscar merged commit 079eaed into main Sep 4, 2025
25 checks passed

rmartinoscar deleted the fix/Translations branch September 4, 2025 19:39

github-actions bot locked and limited conversation to collaborators Sep 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix finish & add translation for Installer title #1659

Fix finish & add translation for Installer title #1659

Uh oh!

rmartinoscar commented Sep 4, 2025

Uh oh!

coderabbitai bot commented Sep 4, 2025 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Status, Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Fix finish & add translation for Installer title #1659

Fix finish & add translation for Installer title #1659

Uh oh!

Conversation

rmartinoscar commented Sep 4, 2025

Uh oh!

coderabbitai bot commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Chat

Support

CodeRabbit Commands (Invoked using PR/Issue comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Status, Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coderabbitai bot commented Sep 4, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)