-
-
Notifications
You must be signed in to change notification settings - Fork 254
Remove table row icons #1710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove table row icons #1710
Conversation
📝 WalkthroughWalkthroughRemoved icon() decorators from multiple Filament table columns and one action across various admin resources, pages, and relation managers. All changes are presentation-only; no data retrieval, control flow, or public API signatures were modified. Changes
Possibly related PRs
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR systematically removes icon properties from table row columns across the Filament admin interface, simplifying the table display by relying on column headers instead of repetitive row-level icons.
- Removes
.icon()method calls from TextColumn definitions in table configurations - Maintains all other column functionality including labels, sorting, and searchability
- Affects multiple resource files including Users, Servers, Nodes, Eggs, and related managers
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| app/Filament/Admin/Resources/Users/UserResource.php | Removes icons from email, roles, servers, and subusers columns |
| app/Filament/Admin/Resources/Users/RelationManagers/ServersRelationManager.php | Removes icons from server name, node, egg, databases, and backups columns |
| app/Filament/Admin/Resources/Servers/RelationManagers/DatabasesRelationManager.php | Removes icons from database, username, and server name columns |
| app/Filament/Admin/Resources/Servers/Pages/ListServers.php | Removes icons from server name, node, egg, user, backups columns and view action |
| app/Filament/Admin/Resources/Roles/RoleResource.php | Removes icons from nodes and users count columns |
| app/Filament/Admin/Resources/Nodes/RelationManagers/NodesRelationManager.php | Removes icons from user, server name, egg, memory, CPU, databases, and backups columns |
| app/Filament/Admin/Resources/Nodes/Pages/ListNodes.php | Removes icons from node name, FQDN, and servers count columns |
| app/Filament/Admin/Resources/Mounts/MountResource.php | Removes icons from eggs and nodes columns |
| app/Filament/Admin/Resources/Eggs/RelationManagers/ServersRelationManager.php | Removes icons from user, server name, and node columns |
| app/Filament/Admin/Resources/Eggs/Pages/ListEggs.php | Removes icons from egg name and servers count columns |
| app/Filament/Admin/Resources/DatabaseHosts/RelationManagers/DatabasesRelationManager.php | Removes icons from database, username, and server name columns |
| app/Filament/Admin/Resources/DatabaseHosts/DatabaseHostResource.php | Removes icons from databases count and nodes columns |
| app/Filament/Admin/Resources/ApiKeys/ApiKeyResource.php | Removes icons from key and user columns |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@coderabbitai generate docstrings |
|
Warning Docstrings generation is disabled for your repository or organization. |
This comment was marked as outdated.
This comment was marked as outdated.
|
But I think I like the icons in every row 🤔 |
|
It's just so repetitive. Example, List Eggs - Each egg name has an egg icon before it... why? |
Removes the table row icons that are in every row; we have table headers, and that should be sufficient. It would be nice to have the icon in the header, but that does not seem like an option at the moment.