Skip to content

Conversation

@notAreYouScared
Copy link
Member

Removes the table row icons that are in every row; we have table headers, and that should be sufficient. It would be nice to have the icon in the header, but that does not seem like an option at the moment.

@coderabbitai
Copy link

coderabbitai bot commented Sep 15, 2025

📝 Walkthrough

Walkthrough

Removed icon() decorators from multiple Filament table columns and one action across various admin resources, pages, and relation managers. All changes are presentation-only; no data retrieval, control flow, or public API signatures were modified.

Changes

Cohort / File(s) Change Summary
API Keys
app/Filament/Admin/Resources/ApiKeys/ApiKeyResource.php
Removed icon from user.username TextColumn; key column retained its icon.
Database Hosts
app/Filament/Admin/Resources/DatabaseHosts/DatabaseHostResource.php, app/Filament/Admin/Resources/DatabaseHosts/RelationManagers/DatabasesRelationManager.php
Removed icons from databasess_count and nodes.name; relation manager: removed icons from database, username, and server.name.
Eggs
app/Filament/Admin/Resources/Eggs/Pages/ListEggs.php, app/Filament/Admin/Resources/Eggs/RelationManagers/ServersRelationManager.php
Removed icons from name and servers_count; relation manager: removed icons from user.username, name, and node.name.
Mounts
app/Filament/Admin/Resources/Mounts/MountResource.php
Removed icons from eggs.name and nodes.name TextColumns.
Nodes
app/Filament/Admin/Resources/Nodes/Pages/ListNodes.php, app/Filament/Admin/Resources/Nodes/RelationManagers/NodesRelationManager.php
Removed icons from name, fqdn, and servers_count; relation manager: removed icons from user.username, name, egg.name, memory, cpu, databases_count, backups_count.
Roles
app/Filament/Admin/Resources/Roles/RoleResource.php
Removed icons from nodes.name and users_count TextColumns.
Servers
app/Filament/Admin/Resources/Servers/Pages/ListServers.php, app/Filament/Admin/Resources/Servers/RelationManagers/DatabasesRelationManager.php
Removed icons from name, node.name, egg.name, user.username, backups_count; removed icon from the View action; relation manager: removed icons from database, username, server.name.
Users
app/Filament/Admin/Resources/Users/UserResource.php, app/Filament/Admin/Resources/Users/RelationManagers/ServersRelationManager.php
Removed icons from email, roles.name, servers_count, subusers_count; relation manager: removed icons from name, node.name, egg.name, databases_count, backups_count.

Possibly related PRs

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 46.15% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title "Remove table row icons" is concise and accurately summarizes the primary change in this PR: removal of per-row Filament table icons across multiple resources (the raw_summary shows icon() removals in many files). It is specific, short, and clear for a teammate scanning the commit history.
Description Check ✅ Passed The description plainly explains the intent and scope—removing table row icons because headers are sufficient and noting a preference to add icons to headers if possible—which directly matches the changes shown in the raw_summary, so it is related to the changeset.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b44d41d and 4409cf0.

📒 Files selected for processing (1)
  • app/Filament/Admin/Resources/ApiKeys/ApiKeyResource.php (0 hunks)
💤 Files with no reviewable changes (1)
  • app/Filament/Admin/Resources/ApiKeys/ApiKeyResource.php

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR systematically removes icon properties from table row columns across the Filament admin interface, simplifying the table display by relying on column headers instead of repetitive row-level icons.

  • Removes .icon() method calls from TextColumn definitions in table configurations
  • Maintains all other column functionality including labels, sorting, and searchability
  • Affects multiple resource files including Users, Servers, Nodes, Eggs, and related managers

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
app/Filament/Admin/Resources/Users/UserResource.php Removes icons from email, roles, servers, and subusers columns
app/Filament/Admin/Resources/Users/RelationManagers/ServersRelationManager.php Removes icons from server name, node, egg, databases, and backups columns
app/Filament/Admin/Resources/Servers/RelationManagers/DatabasesRelationManager.php Removes icons from database, username, and server name columns
app/Filament/Admin/Resources/Servers/Pages/ListServers.php Removes icons from server name, node, egg, user, backups columns and view action
app/Filament/Admin/Resources/Roles/RoleResource.php Removes icons from nodes and users count columns
app/Filament/Admin/Resources/Nodes/RelationManagers/NodesRelationManager.php Removes icons from user, server name, egg, memory, CPU, databases, and backups columns
app/Filament/Admin/Resources/Nodes/Pages/ListNodes.php Removes icons from node name, FQDN, and servers count columns
app/Filament/Admin/Resources/Mounts/MountResource.php Removes icons from eggs and nodes columns
app/Filament/Admin/Resources/Eggs/RelationManagers/ServersRelationManager.php Removes icons from user, server name, and node columns
app/Filament/Admin/Resources/Eggs/Pages/ListEggs.php Removes icons from egg name and servers count columns
app/Filament/Admin/Resources/DatabaseHosts/RelationManagers/DatabasesRelationManager.php Removes icons from database, username, and server name columns
app/Filament/Admin/Resources/DatabaseHosts/DatabaseHostResource.php Removes icons from databases count and nodes columns
app/Filament/Admin/Resources/ApiKeys/ApiKeyResource.php Removes icons from key and user columns

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@notAreYouScared
Copy link
Member Author

@coderabbitai generate docstrings

@coderabbitai
Copy link

coderabbitai bot commented Sep 15, 2025

Warning

Docstrings generation is disabled for your repository or organization.

@coderabbitai

This comment was marked as outdated.

@lancepioch
Copy link
Member

But I think I like the icons in every row 🤔

@notAreYouScared
Copy link
Member Author

It's just so repetitive.

Example,

List Eggs - Each egg name has an egg icon before it... why?
We know they're eggs... The same with server count, and any other thing that's a count.

@notAreYouScared notAreYouScared merged commit 3d2390d into main Sep 16, 2025
25 checks passed
@notAreYouScared notAreYouScared deleted the charles/remove-icons branch September 16, 2025 15:45
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants