Skip to content

Conversation

@notAreYouScared
Copy link
Member

@notAreYouScared notAreYouScared commented Nov 9, 2025

Should cover, most if not all the actions that have duplicate notifications

Closes #1859

@coderabbitai
Copy link

coderabbitai bot commented Nov 9, 2025

📝 Walkthrough

Walkthrough

Suppresses success notification titles across four Filament resource files by adding successNotificationTitle(null) fluent calls to DeleteAction, CreateAction, and EditAction configurations in DatabasesRelationManager, BackupResource, DatabaseResource, and UserResource.

Changes

Cohort / File(s) Summary
Suppress success notification titles
app/Filament/Admin/Resources/Servers/RelationManagers/DatabasesRelationManager.php, app/Filament/Server/Resources/Backups/BackupResource.php, app/Filament/Server/Resources/Databases/DatabaseResource.php, app/Filament/Server/Resources/Users/UserResource.php
Added successNotificationTitle(null) to action chains: DeleteAction in DatabasesRelationManager and BackupResource/DatabaseResource; CreateAction in BackupResource and DatabaseResource; EditAction in UserResource. Suppresses success notification titles for these operations without altering execution flow or error handling.

Possibly related PRs

  • Refactor & Catch DatabaseManagementService #1671: Modifies the same Filament action handlers in DatabaseResource and related resources, changing notification behavior for create/delete actions through different mechanisms (try/catch and explicit notifications vs. notification title suppression).

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Do no use stock notifications on actions' directly describes the main change: suppressing default/stock success notification titles across multiple Filament actions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description clearly relates to the changeset, which suppresses success notification titles across multiple Filament actions to address duplicate notifications.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@notAreYouScared notAreYouScared merged commit d8368c4 into main Nov 9, 2025
25 checks passed
@notAreYouScared notAreYouScared deleted the charles/fix-notifi branch November 9, 2025 17:08
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some actions result in multiple notifications

4 participants