Use public disk for console fonts upload

[rmartinoscar]

Closes #1886

[coderabbitai]

📝 Walkthrough

Walkthrough

Modified the FileUpload field for ConsoleFonts in the admin settings page to explicitly specify the public disk as the storage destination, addressing the issue where uploaded console fonts were not being persisted correctly.

Changes

Cohort / File(s)	Change Summary
Settings Page Configuration app/Filament/Admin/Pages/Settings.php	Added disk('public') configuration to the ConsoleFonts FileUpload field in the misc settings tab to specify the public disk as the storage destination for uploaded console fonts.

Pre-merge checks

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and concisely describes the main code change: adding the public disk configuration for console fonts upload.
Description check	✅ Passed	The description references issue #1886, which is directly related to the bug fix implemented in the changeset.
Linked Issues check	✅ Passed	The code change adds disk('public') to FileUpload for ConsoleFonts, which directly addresses issue #1886's requirement that uploaded fonts be accessible and available in the panel.
Out of Scope Changes check	✅ Passed	The change is narrowly scoped to adding the public disk configuration for console fonts upload, with no unrelated modifications present.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 89199df and 5f52b13.

📒 Files selected for processing (1)

• app/Filament/Admin/Pages/Settings.php (1 hunks)

🔇 Additional comments (1)

app/Filament/Admin/Pages/Settings.php (1)

791-791: The review comment is incorrect.

The code at line 791 correctly excludes ConsoleFonts from environment data. The storage:link setup is already part of the official setup process via p:environment:setup command, which explicitly calls storage:link as part of application initialization. The missing storage symlink in the current state is expected—it's a deployment requirement, not a code defect. No code changes are needed for this review comment's concern.

Likely an incorrect or invalid review comment.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}