Skip to content

Conversation

@rmartinoscar
Copy link
Member

Closes #1920

@coderabbitai
Copy link

coderabbitai bot commented Nov 23, 2025

📝 Walkthrough

Walkthrough

Modified the getBreadcrumbs method in the file editor page to generate breadcrumb navigation URLs using the ListFiles::getUrl() method instead of the current class's URL generator, resolving breadcrumb navigation to parent folders.

Changes

Cohort / File(s) Summary
File Editor Breadcrumb Navigation
app/Filament/Server/Resources/Files/Pages/EditFiles.php
Updated getBreadcrumbs method to use ListFiles::getUrl(...) for generating breadcrumb URLs for nested path segments instead of self::getUrl(...)

Possibly related PRs

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: fixing incorrect breadcrumb URLs in the EditFiles page.
Description check ✅ Passed The description references issue #1920 which relates to the breadcrumb navigation bug being fixed.
Linked Issues check ✅ Passed The code change directly addresses issue #1920 by fixing breadcrumb URL resolution to use ListFiles::getUrl() instead of self::getUrl(), resolving the broken navigation to parent folders.
Out of Scope Changes check ✅ Passed The change is narrowly scoped to fixing the breadcrumb URL generation in EditFiles, directly addressing the linked issue with no extraneous modifications.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 25c8ff3 and 1bcddba.

📒 Files selected for processing (1)
  • app/Filament/Server/Resources/Files/Pages/EditFiles.php (1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
app/Filament/Server/Resources/Files/Pages/EditFiles.php (1)
app/Filament/Server/Resources/Files/Pages/ListFiles.php (1)
  • ListFiles (51-698)
🔇 Additional comments (1)
app/Filament/Server/Resources/Files/Pages/EditFiles.php (1)

270-270: Correct fix for breadcrumb navigation.

The change from self::getUrl() to ListFiles::getUrl() properly resolves the breadcrumb navigation issue. Breadcrumbs should navigate to the file listing view (ListFiles) when clicking folder segments, not attempt to open folders in the file editor (EditFiles). This is consistent with the redirectToList() method at line 208 and matches the breadcrumb pattern used in ListFiles itself.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rmartinoscar rmartinoscar merged commit b1b7234 into main Nov 23, 2025
25 checks passed
@rmartinoscar rmartinoscar deleted the issue/1920 branch November 23, 2025 23:42
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken navigation to parent folder from file editor

3 participants