Skip to content

Conversation

@notAreYouScared
Copy link
Member

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Dec 9, 2025

📝 Walkthrough

Walkthrough

This pull request updates Docker image registry references across application code, database seeders, and tests. The images are migrated from ghcr.io/parkervcp/* to ghcr.io/pelican-eggs/*, affecting placeholder values, sample data, game server configuration seeders, and test fixtures.

Changes

Cohort / File(s) Change Summary
Application Code
app/Filament/Admin/Resources/Eggs/Pages/CreateEgg.php, app/Models/WebhookConfiguration.php
Updated Docker image references in placeholder and sample webhook data from parkervcp to pelican-eggs registry domain.
Minecraft Egg Seeders
database/Seeders/eggs/minecraft/egg-bungeecord.yaml, egg-forge-minecraft.yaml, egg-paper.yaml, egg-sponge.yaml, egg-vanilla-minecraft.yaml
Updated all docker_images Java version mappings and installation script container references from ghcr.io/parkervcp/* to ghcr.io/pelican-eggs/*. Forge seeder also updated exported timestamp and Forge installer container.
Rust & Source Engine Egg Seeders
database/Seeders/eggs/rust/egg-rust.yaml, database/Seeders/eggs/source-engine/egg-*.yaml
Updated docker_images entries and installation script container references from parkervcp to pelican-eggs registry across Rust and Source Engine game seeders (Custom Source Engine, Garry's Mod, Insurgency, Team Fortress 2).
Voice Server Egg Seeders
database/Seeders/eggs/voice-servers/egg-mumble-server.yaml, egg-teamspeak3-server.yaml
Updated docker_images and installation script container references from parkervcp to pelican-eggs.
Test Fixtures
tests/Feature/SettingsControllerTest.php
Updated test data and expected values for Docker image references to use pelican-eggs domain instead of parkervcp.

Pre-merge checks

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to verify if the description relates to the changeset. Add a pull request description explaining the purpose of updating egg images, the migration from parkervcp to pelican-eggs registry, and any relevant context or breaking changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Update Stock Egg Images' accurately reflects the core change of updating Docker image references across multiple egg configuration files from parkervcp to pelican-eggs registry.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
database/Seeders/eggs/minecraft/egg-bungeecord.yaml (1)

24-28: Yolk registry updated; consider also migrating the installer image

The Java yolk mappings now point at ghcr.io/pelican-eggs/yolks:java_*, consistent with other Minecraft eggs. The installer container, however, is still ghcr.io/parkervcp/installers:alpine (line 60, unchanged here). If the goal is a full move off the parkervcp namespace, you may want to update that container to the corresponding pelican-eggs/installers image as well.

tests/Feature/SettingsControllerTest.php (1)

84-84: Test fixtures aligned to pelican-eggs images, with one remaining pelican-dev reference

The Docker image fixtures in these tests now generally reference ghcr.io/pelican-eggs/yolks:..., which lines up with the new seed defaults and UI placeholders. One exception is the unauthorized-image test (line 84) still using ghcr.io/pelican-dev/yolks:java_21. Functionally this is fine (the test only asserts lack of permission), but for consistency with the rest of the suite you might want to switch it to ghcr.io/pelican-eggs/yolks:java_21 as well.

Also applies to: 96-96, 99-99, 116-116, 120-120, 139-139, 143-143

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7a95712 and 95d317a.

📒 Files selected for processing (15)
  • app/Filament/Admin/Resources/Eggs/Pages/CreateEgg.php (1 hunks)
  • app/Models/WebhookConfiguration.php (1 hunks)
  • database/Seeders/eggs/minecraft/egg-bungeecord.yaml (1 hunks)
  • database/Seeders/eggs/minecraft/egg-forge-minecraft.yaml (3 hunks)
  • database/Seeders/eggs/minecraft/egg-paper.yaml (2 hunks)
  • database/Seeders/eggs/minecraft/egg-sponge.yaml (2 hunks)
  • database/Seeders/eggs/minecraft/egg-vanilla-minecraft.yaml (2 hunks)
  • database/Seeders/eggs/rust/egg-rust.yaml (2 hunks)
  • database/Seeders/eggs/source-engine/egg-custom-source-engine-game.yaml (2 hunks)
  • database/Seeders/eggs/source-engine/egg-garrys-mod.yaml (2 hunks)
  • database/Seeders/eggs/source-engine/egg-insurgency.yaml (2 hunks)
  • database/Seeders/eggs/source-engine/egg-team-fortress2.yaml (2 hunks)
  • database/Seeders/eggs/voice-servers/egg-mumble-server.yaml (2 hunks)
  • database/Seeders/eggs/voice-servers/egg-teamspeak3-server.yaml (2 hunks)
  • tests/Feature/SettingsControllerTest.php (3 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: notAreYouScared
Repo: pelican-dev/panel PR: 1849
File: database/Seeders/eggs/minecraft/egg-sponge.yaml:10-10
Timestamp: 2025-10-31T13:18:53.083Z
Learning: The egg image field accepts multiple image formats including SVG (data:image/svg+xml;base64,...) and PNG (data:image/png;base64,...), not exclusively PNG as initially documented in PR #1849.
🔇 Additional comments (13)
database/Seeders/eggs/source-engine/egg-garrys-mod.yaml (1)

20-20: Image and installer container registry swap looks consistent

docker_images.Source and the installer container are both moved to the ghcr.io/pelican-eggs/... namespace, matching the rest of the PR’s migration. No behavioral changes beyond using the new images.

Also applies to: 134-134

app/Filament/Admin/Resources/Eggs/Pages/CreateEgg.php (1)

130-130: Docker image placeholder updated to new yolk registry

The docker_images value placeholder now points at ghcr.io/pelican-eggs/yolks:java_21, which aligns with the updated seed data and tests. No issues from a form/validation perspective.

app/Models/WebhookConfiguration.php (1)

224-224: Webhook sample image updated to pelican-eggs

The sample payload’s image now matches the new ghcr.io/pelican-eggs/yolks:java_21 reference used elsewhere. This keeps docs/test payloads aligned with the current default eggs.

database/Seeders/eggs/voice-servers/egg-mumble-server.yaml (1)

17-17: Voice server egg now fully using pelican-eggs images

Both docker_images.Mumble and the installer container are switched to ghcr.io/pelican-eggs/..., consistent with the rest of the registry migration. YAML and values look correct.

Also applies to: 56-56

database/Seeders/eggs/source-engine/egg-team-fortress2.yaml (1)

20-20: Source-engine egg image and installer moved to pelican-eggs

docker_images.Source and the install container now reference the pelican-eggs registry, matching the Garry’s Mod and other source-engine eggs. Change is scoped to image strings only.

Also applies to: 85-85

database/Seeders/eggs/minecraft/egg-forge-minecraft.yaml (1)

5-5: Forge egg metadata and images updated to pelican-eggs

  • exported_at refreshed to the new export timestamp.
  • All Java yolk mappings now point at ghcr.io/pelican-eggs/yolks:java_*.
  • The installer container is updated to ghcr.io/pelican-eggs/installers:java_8, matching the Java 8 requirement in the script.

All changes are consistent with the registry migration elsewhere in the PR.

Also applies to: 20-24, 171-171

database/Seeders/eggs/source-engine/egg-custom-source-engine-game.yaml (1)

19-19: Registry migration applied correctly.

Both docker image references have been updated consistently from parkervcp to pelican-eggs registry.

Also applies to: 84-84

database/Seeders/eggs/voice-servers/egg-teamspeak3-server.yaml (1)

17-17: Registry migration applied correctly.

Both docker image references have been updated consistently from parkervcp to pelican-eggs registry.

Also applies to: 44-44

database/Seeders/eggs/rust/egg-rust.yaml (1)

21-21: Registry migration applied correctly.

Both docker image references have been updated consistently from parkervcp to pelican-eggs registry.

Also applies to: 76-76

database/Seeders/eggs/minecraft/egg-paper.yaml (1)

18-22: Registry migration applied correctly across all Java versions.

All five Java version docker image references and the installer container have been updated consistently from parkervcp to pelican-eggs registry.

Also applies to: 94-94

database/Seeders/eggs/minecraft/egg-sponge.yaml (1)

18-22: Registry migration applied correctly across all Java versions.

All five Java version docker image references and the installer container have been updated consistently from parkervcp to pelican-eggs registry.

Also applies to: 106-106

database/Seeders/eggs/minecraft/egg-vanilla-minecraft.yaml (1)

22-26: Registry migration applied correctly across all Java versions.

All five Java version docker image references and the installer container have been updated consistently from parkervcp to pelican-eggs registry.

Also applies to: 72-72

database/Seeders/eggs/source-engine/egg-insurgency.yaml (1)

20-20: Registry migration applied correctly.

Both docker image references have been updated consistently from parkervcp to pelican-eggs registry.

Also applies to: 60-60

Copy link
Contributor

@parkervcp parkervcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@notAreYouScared notAreYouScared merged commit dfd6dbf into main Dec 9, 2025
25 checks passed
@notAreYouScared notAreYouScared deleted the charles/fix-forge branch December 9, 2025 22:53
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants