-
-
Notifications
You must be signed in to change notification settings - Fork 254
Update Stock Egg Images #1973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Stock Egg Images #1973
Conversation
📝 WalkthroughWalkthroughThis pull request updates Docker image registry references across application code, database seeders, and tests. The images are migrated from Changes
Pre-merge checks❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
database/Seeders/eggs/minecraft/egg-bungeecord.yaml (1)
24-28: Yolk registry updated; consider also migrating the installer imageThe Java yolk mappings now point at
ghcr.io/pelican-eggs/yolks:java_*, consistent with other Minecraft eggs. The installer container, however, is stillghcr.io/parkervcp/installers:alpine(line 60, unchanged here). If the goal is a full move off theparkervcpnamespace, you may want to update that container to the correspondingpelican-eggs/installersimage as well.tests/Feature/SettingsControllerTest.php (1)
84-84: Test fixtures aligned to pelican-eggs images, with one remaining pelican-dev referenceThe Docker image fixtures in these tests now generally reference
ghcr.io/pelican-eggs/yolks:..., which lines up with the new seed defaults and UI placeholders. One exception is the unauthorized-image test (line 84) still usingghcr.io/pelican-dev/yolks:java_21. Functionally this is fine (the test only asserts lack of permission), but for consistency with the rest of the suite you might want to switch it toghcr.io/pelican-eggs/yolks:java_21as well.Also applies to: 96-96, 99-99, 116-116, 120-120, 139-139, 143-143
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (15)
app/Filament/Admin/Resources/Eggs/Pages/CreateEgg.php(1 hunks)app/Models/WebhookConfiguration.php(1 hunks)database/Seeders/eggs/minecraft/egg-bungeecord.yaml(1 hunks)database/Seeders/eggs/minecraft/egg-forge-minecraft.yaml(3 hunks)database/Seeders/eggs/minecraft/egg-paper.yaml(2 hunks)database/Seeders/eggs/minecraft/egg-sponge.yaml(2 hunks)database/Seeders/eggs/minecraft/egg-vanilla-minecraft.yaml(2 hunks)database/Seeders/eggs/rust/egg-rust.yaml(2 hunks)database/Seeders/eggs/source-engine/egg-custom-source-engine-game.yaml(2 hunks)database/Seeders/eggs/source-engine/egg-garrys-mod.yaml(2 hunks)database/Seeders/eggs/source-engine/egg-insurgency.yaml(2 hunks)database/Seeders/eggs/source-engine/egg-team-fortress2.yaml(2 hunks)database/Seeders/eggs/voice-servers/egg-mumble-server.yaml(2 hunks)database/Seeders/eggs/voice-servers/egg-teamspeak3-server.yaml(2 hunks)tests/Feature/SettingsControllerTest.php(3 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: notAreYouScared
Repo: pelican-dev/panel PR: 1849
File: database/Seeders/eggs/minecraft/egg-sponge.yaml:10-10
Timestamp: 2025-10-31T13:18:53.083Z
Learning: The egg image field accepts multiple image formats including SVG (data:image/svg+xml;base64,...) and PNG (data:image/png;base64,...), not exclusively PNG as initially documented in PR #1849.
🔇 Additional comments (13)
database/Seeders/eggs/source-engine/egg-garrys-mod.yaml (1)
20-20: Image and installer container registry swap looks consistent
docker_images.Sourceand the installercontainerare both moved to theghcr.io/pelican-eggs/...namespace, matching the rest of the PR’s migration. No behavioral changes beyond using the new images.Also applies to: 134-134
app/Filament/Admin/Resources/Eggs/Pages/CreateEgg.php (1)
130-130: Docker image placeholder updated to new yolk registryThe
docker_imagesvalue placeholder now points atghcr.io/pelican-eggs/yolks:java_21, which aligns with the updated seed data and tests. No issues from a form/validation perspective.app/Models/WebhookConfiguration.php (1)
224-224: Webhook sampleimageupdated to pelican-eggsThe sample payload’s
imagenow matches the newghcr.io/pelican-eggs/yolks:java_21reference used elsewhere. This keeps docs/test payloads aligned with the current default eggs.database/Seeders/eggs/voice-servers/egg-mumble-server.yaml (1)
17-17: Voice server egg now fully using pelican-eggs imagesBoth
docker_images.Mumbleand the installercontainerare switched toghcr.io/pelican-eggs/..., consistent with the rest of the registry migration. YAML and values look correct.Also applies to: 56-56
database/Seeders/eggs/source-engine/egg-team-fortress2.yaml (1)
20-20: Source-engine egg image and installer moved to pelican-eggs
docker_images.Sourceand the installcontainernow reference thepelican-eggsregistry, matching the Garry’s Mod and other source-engine eggs. Change is scoped to image strings only.Also applies to: 85-85
database/Seeders/eggs/minecraft/egg-forge-minecraft.yaml (1)
5-5: Forge egg metadata and images updated to pelican-eggs
exported_atrefreshed to the new export timestamp.- All Java yolk mappings now point at
ghcr.io/pelican-eggs/yolks:java_*.- The installer
containeris updated toghcr.io/pelican-eggs/installers:java_8, matching the Java 8 requirement in the script.All changes are consistent with the registry migration elsewhere in the PR.
Also applies to: 20-24, 171-171
database/Seeders/eggs/source-engine/egg-custom-source-engine-game.yaml (1)
19-19: Registry migration applied correctly.Both docker image references have been updated consistently from
parkervcptopelican-eggsregistry.Also applies to: 84-84
database/Seeders/eggs/voice-servers/egg-teamspeak3-server.yaml (1)
17-17: Registry migration applied correctly.Both docker image references have been updated consistently from
parkervcptopelican-eggsregistry.Also applies to: 44-44
database/Seeders/eggs/rust/egg-rust.yaml (1)
21-21: Registry migration applied correctly.Both docker image references have been updated consistently from
parkervcptopelican-eggsregistry.Also applies to: 76-76
database/Seeders/eggs/minecraft/egg-paper.yaml (1)
18-22: Registry migration applied correctly across all Java versions.All five Java version docker image references and the installer container have been updated consistently from
parkervcptopelican-eggsregistry.Also applies to: 94-94
database/Seeders/eggs/minecraft/egg-sponge.yaml (1)
18-22: Registry migration applied correctly across all Java versions.All five Java version docker image references and the installer container have been updated consistently from
parkervcptopelican-eggsregistry.Also applies to: 106-106
database/Seeders/eggs/minecraft/egg-vanilla-minecraft.yaml (1)
22-26: Registry migration applied correctly across all Java versions.All five Java version docker image references and the installer container have been updated consistently from
parkervcptopelican-eggsregistry.Also applies to: 72-72
database/Seeders/eggs/source-engine/egg-insurgency.yaml (1)
20-20: Registry migration applied correctly.Both docker image references have been updated consistently from
parkervcptopelican-eggsregistry.Also applies to: 60-60
parkervcp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.