Skip to content

Conversation

@notAreYouScared
Copy link
Member

@notAreYouScared notAreYouScared commented Dec 13, 2025

Fixes #1997

image

@coderabbitai
Copy link

coderabbitai bot commented Dec 13, 2025

📝 Walkthrough

Walkthrough

Modified the accepted file types in the ImportEggAction FileUpload component to properly include YAML files. Changed from accepting MIME types application/yaml, application/x-yaml, text/yaml to application/x-yaml, text/yaml, .yaml, .yml file extensions, removing application/yaml and adding explicit .yaml and .yml extension declarations.

Changes

Cohort / File(s) Change Summary
Import Egg File Type Configuration
app/Filament/Components/Actions/ImportEggAction.php
Updated acceptedFileTypes array: removed application/yaml, reordered MIME types, and added explicit .yaml and .yml file extension declarations to ensure YAML files appear in file browser dialogs.

Pre-merge checks

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix Egg Importer Upload File Type Filter' directly describes the primary change in the PR, which modifies the acceptedFileTypes in ImportEggAction to properly filter YAML and JSON files.
Description check ✅ Passed The description references the linked issue #1997 about missing YAML file types in egg import dialogs, which is directly related to the changes made in the PR.
Linked Issues check ✅ Passed The code changes address the core requirement: updating acceptedFileTypes to include YAML extensions (.yaml, .yml) alongside JSON, enabling proper file filtering in the import dialog.
Out of Scope Changes check ✅ Passed All changes are focused on modifying the file type filter in ImportEggAction.php, which is directly within scope of fixing the YAML file type selection issue.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fdd9faa and 7023e64.

📒 Files selected for processing (1)
  • app/Filament/Components/Actions/ImportEggAction.php (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: notAreYouScared
Repo: pelican-dev/panel PR: 1849
File: database/Seeders/eggs/minecraft/egg-sponge.yaml:10-10
Timestamp: 2025-10-31T13:18:53.083Z
Learning: The egg image field accepts multiple image formats including SVG (data:image/svg+xml;base64,...) and PNG (data:image/png;base64,...), not exclusively PNG as initially documented in PR #1849.
📚 Learning: 2025-10-31T13:18:53.083Z
Learnt from: notAreYouScared
Repo: pelican-dev/panel PR: 1849
File: database/Seeders/eggs/minecraft/egg-sponge.yaml:10-10
Timestamp: 2025-10-31T13:18:53.083Z
Learning: The egg image field accepts multiple image formats including SVG (data:image/svg+xml;base64,...) and PNG (data:image/png;base64,...), not exclusively PNG as initially documented in PR #1849.

Applied to files:

  • app/Filament/Components/Actions/ImportEggAction.php

@notAreYouScared notAreYouScared merged commit 2f5790b into main Dec 14, 2025
25 checks passed
@notAreYouScared notAreYouScared deleted the charles/fix-eggimport branch December 14, 2025 03:46
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing YAML file type in selection when importing eggs

3 participants