-
-
Notifications
You must be signed in to change notification settings - Fork 254
Fix Egg Importer Upload File Type Filter #2000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughModified the accepted file types in the ImportEggAction FileUpload component to properly include YAML files. Changed from accepting MIME types Changes
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
app/Filament/Components/Actions/ImportEggAction.php(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: notAreYouScared
Repo: pelican-dev/panel PR: 1849
File: database/Seeders/eggs/minecraft/egg-sponge.yaml:10-10
Timestamp: 2025-10-31T13:18:53.083Z
Learning: The egg image field accepts multiple image formats including SVG (data:image/svg+xml;base64,...) and PNG (data:image/png;base64,...), not exclusively PNG as initially documented in PR #1849.
📚 Learning: 2025-10-31T13:18:53.083Z
Learnt from: notAreYouScared
Repo: pelican-dev/panel PR: 1849
File: database/Seeders/eggs/minecraft/egg-sponge.yaml:10-10
Timestamp: 2025-10-31T13:18:53.083Z
Learning: The egg image field accepts multiple image formats including SVG (data:image/svg+xml;base64,...) and PNG (data:image/png;base64,...), not exclusively PNG as initially documented in PR #1849.
Applied to files:
app/Filament/Components/Actions/ImportEggAction.php
Fixes #1997