178 add benchmarks for custom pallets per runtime#453
Conversation
Should we just add them then or is there a good reason not to?
What changes require the redeployment of the collator nodes? |
Yes, we should add them. They're not added yet because I'm still getting some errors on some benchmarks and I'm trying to fix them.
I modified |
|
Is this now ready for a re-review or are you still adding more changes to it? |
Still adding changes |
…o 178-add-benchmarks-for-custom-pallets-per-runtime
…o 178-add-benchmarks-for-custom-pallets-per-runtime
|
@bogdanS98 what's the status with this? Do you need help here? |
|
Any actions for us to take wrt the node upgrades @ebma ? |
|
Good question @vadaynujra. @bogdanS98 in the description you mention that the nodes need to be redeployed. Looking at the PR, there are some changes to files in the node folder. However, to me it seems like these changes don't really require a redeployment. Changing the chain spec does not affect the operation of the nodes. What do you think? |
|
@ebma Indeed changing the chain spec does not affect the operation of the nodes, I'll update the description 👍🏼 |
9c61153 to
9a5307b
Compare
…ttps://github.com/pendulum-chain/pendulum into 178-add-benchmarks-for-custom-pallets-per-runtime
Co-authored-by: Marcel Ebert <mail@marcel-ebert.de>
Co-authored-by: Marcel Ebert <mail@marcel-ebert.de>
Co-authored-by: Marcel Ebert <mail@marcel-ebert.de>
Closes #178.