24 bug pipeline docker build fail#25
Merged
Merged
Conversation
…hing - Adjusted the `tools-publish.yml` workflow to use `github.repository_owner` for Docker login instead of `github.actor`. - Reformatted the table in `manual-publish.md` for improved readability, ensuring consistent alignment of headers and values.
- Removed the deprecated `compute-image-tags.sh` script and introduced `merge-multiarch-manifest.sh` to handle merging single-arch image references into a multi-arch tag. - Updated the `tools-publish.yml` workflow to support building images for both `amd64` and `arm64` architectures, utilizing conditional runners based on architecture. - Enhanced documentation in `manual-publish.md` to clarify the CI build process for different architectures and the implications of using QEMU for arm64 builds.
- Introduced a new GitHub Actions workflow (`ghcr-verify.yml`) to verify GHCR login by pushing a minimal image and performing a read check. - Added a Dockerfile for the verification context to facilitate the image push. - Updated tool image references in various files to reflect the new repository structure (`ghcr.io/pengine-ai/pengine-<suffix>` instead of `ghcr.io/pengine-ai/tools/pengine-<suffix>`). - Enhanced the `write-publish-summary.sh` script to include optional runner architecture information in the summary output.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (11)
📝 WalkthroughWalkthroughThe pull request restructures the container image publishing pipeline to build images separately per architecture (amd64 and arm64) before merging them into a single multi-arch manifest, while also simplifying the GHCR repository path structure from Changes
Sequence Diagram(s)sequenceDiagram
participant W as Workflow
participant B as docker buildx
participant R as GHCR Registry
participant M as imagetools
W->>B: Build linux/amd64 image
B->>R: Push as :${VERSION}-ci-amd64-${RUN_ID}
R-->>W: Return amd64 ref (AMD_REF)
W->>B: Build linux/arm64 image
B->>R: Push as :${VERSION}-ci-arm64-${RUN_ID}
R-->>W: Return arm64 ref (ARM_REF)
W->>M: imagetools create with AMD_REF + ARM_REF
M->>R: Publish manifest list as :${VERSION}, :latest
R-->>W: Return manifest digest
W->>W: Write digest to GITHUB_OUTPUT
W->>R: Later: pull by digest for verification
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Chores
Documentation