Skip to content

Fix deploy pipeline#76

Merged
maximedogawa merged 9 commits into
mainfrom
fix-deploy-pipeline
Apr 19, 2026
Merged

Fix deploy pipeline#76
maximedogawa merged 9 commits into
mainfrom
fix-deploy-pipeline

Conversation

@maximedogawa
Copy link
Copy Markdown
Collaborator

@maximedogawa maximedogawa commented Apr 19, 2026

Summary by CodeRabbit

  • Chores

    • Updated deployment infrastructure, including GitHub Actions workflow and Docker configurations.
    • Adjusted build and deployment file paths and settings.
  • Documentation

    • Updated deployment guide to reflect current configuration paths and image naming conventions.

… files

- Replaced the checkout action in the GitHub Actions workflow to use `actions/checkout@v5` for improved functionality.
- Updated the Dockerfile to streamline the build process and ensure proper application setup.
- Introduced a new `docker-compose.yml` file for managing the deployment of the web application, including health checks and environment configurations.
- Revised deployment documentation to reflect changes in file paths and deployment procedures.
- Introduced a new script `build:web:ci` in `package.json` for CI-specific builds.
- Updated the deployment workflow to reference the correct path for `docker-compose.yml`.
- Modified the Dockerfile to use the new CI build script, ensuring consistency in the build process.
- Removed the CI-specific build script `build:web:ci` from `package.json`.
- Updated the Dockerfile to use `npm install --frozen-lockfile` and adjusted the build command to `npm run build:web`, ensuring a streamlined build process.
- Updated the Dockerfile to replace `npm install --frozen-lockfile` with the shorthand `npm i`, streamlining the installation process.
…allation

- Updated the Dockerfile to replace `npm i` with `npm ci --ignore-scripts`, ensuring a cleaner and more reliable installation of dependencies in production environments.
…justments

- Added a step to capture the short SHA of the current commit in the GitHub Actions workflow.
- Updated the deployment path in the SSH command to navigate to the correct directory for Docker operations.
- Included a strip_components option in the deployment step for improved file handling.
- Eliminated the network aliases for the pengine service in the docker-compose.yml file, simplifying the deployment configuration.
- Modified the deployment command in the GitHub Actions workflow to simplify the Docker compose up process by removing the --remove-orphans flag, ensuring a cleaner deployment without orphaned containers.
@maximedogawa maximedogawa merged commit e7081bc into main Apr 19, 2026
2 of 3 checks passed
@maximedogawa maximedogawa deleted the fix-deploy-pipeline branch April 19, 2026 22:08
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 19, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e55d5a77-affd-4b62-a233-54513897df37

📥 Commits

Reviewing files that changed from the base of the PR and between 8f85b15 and 42dd3a9.

📒 Files selected for processing (4)
  • .github/workflows/web-deploy.yml
  • deployment/Dockerfile
  • deployment/docker-compose.yml
  • doc/guides/deploying-web.md

📝 Walkthrough

Walkthrough

The pull request migrates deployment configuration from a deploy/ directory structure to deployment/, updates the GitHub Actions checkout action to v5, removes Docker network configuration, and updates corresponding documentation and workflow references accordingly.

Changes

Cohort / File(s) Summary
Deployment Configuration
deployment/Dockerfile, deployment/docker-compose.yml
Removed NODE_ENV=production from builder stage and eliminated explicit network attachment and aliases from Docker Compose service configuration.
Workflow Updates
.github/workflows/web-deploy.yml
Updated checkout action to v5, changed Dockerfile and docker-compose paths from deploy/ to deployment/, added strip_components: 1 to SCP configuration, adjusted working directory to ~/pengine/deployment, and simplified docker compose startup command.
Documentation
doc/guides/deploying-web.md
Updated referenced file paths from deploy/ to deployment/, changed Docker image reference from ghcr.io/<owner>/pengine-web:<tag> to ghcr.io/<owner>/pengine/web:<tag>, and adjusted Markdown formatting.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 Hop along, old paths take flight,
To deployment/ we migrate!
Networks untangled, versions renewed,
Our containers dressed fresh and shrewd!

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-deploy-pipeline

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant