Fix docker port issues#77
Merged
Merged
Conversation
…service - Changed the configuration from `expose` to `ports` for the pengine-web service, allowing access to port 1422 from all interfaces. - Added comments to clarify the purpose of the port mapping for local development and Docker interactions.
- Changed the target directory in the GitHub Actions workflow for deployment to ensure proper file placement. - Added a new README.md file in the deployment directory, detailing the deployment process, port configuration, and verification steps for the Pengine application.
- Modified the deployment script to create a subdirectory for deployment files, ensuring better organization and file management during the deployment process.
- Modified docker-compose.yml to connect the Pengine service to the external `pengui-network`, allowing proper communication with Pengui's nginx. - Updated README.md to reflect changes in networking configuration, including deployment order and network name customization for better clarity.
…rking - Added a new section in README.md to address common networking issues related to the Pengine service and the external `pengui-network`. - Included detailed instructions for creating the network and adjusting the `.env` file for compatibility with older network names.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe workflow deployment automation is removed, pivoting from auto-deployment to manual procedures. Deployment documentation and Docker Compose configuration are added to support both standalone and Pengui-integrated setups. Vite's preview server now validates allowed hosts via environment configuration. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Documentation
Chores