Skip to content

update: removed dashboard and setting from web app#81

Merged
maximedogawa merged 1 commit into
mainfrom
80-bug-dashboard-and-setting-not-in-website
Apr 20, 2026
Merged

update: removed dashboard and setting from web app#81
maximedogawa merged 1 commit into
mainfrom
80-bug-dashboard-and-setting-not-in-website

Conversation

@maximedogawa
Copy link
Copy Markdown
Collaborator

@maximedogawa maximedogawa commented Apr 20, 2026

Summary by CodeRabbit

Release Notes

  • New Features

    • App now supports marketing website mode with customized navigation, routes, and features.
    • Landing page displays mode-appropriate call-to-action options (setup wizard or download).
    • Marketing variant includes dedicated About section featuring contact information and legal details.
  • Refactor

    • Reorganized About and legal content into dedicated shared component for improved maintainability.

@maximedogawa maximedogawa linked an issue Apr 20, 2026 that may be closed by this pull request
@maximedogawa maximedogawa merged commit 0f8fea7 into main Apr 20, 2026
1 check was pending
@maximedogawa maximedogawa deleted the 80-bug-dashboard-and-setting-not-in-website branch April 20, 2026 07:28
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 20, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4a2ba5c3-2ec4-45a0-b032-0ccfa1e15d31

📥 Commits

Reviewing files that changed from the base of the PR and between 3fe4e77 and 378ff3c.

📒 Files selected for processing (9)
  • package.json
  • playwright.config.ts
  • src/App.tsx
  • src/pages/LandingPage.tsx
  • src/pages/SettingsPage.tsx
  • src/shared/about/AboutLegalContent.tsx
  • src/shared/runtimeTarget.ts
  • src/shared/ui/TopMenu.tsx
  • src/vite-env.d.ts

📝 Walkthrough

Walkthrough

The pull request introduces runtime environment detection to conditionally enable app routes (setup, dashboard, settings) based on the execution context. A new VITE_ENABLE_APP_ROUTES_IN_BROWSER environment variable controls whether the application displays app-specific routes or operates as a marketing website. Runtime utilities detect Tauri vs. browser contexts, and UI components conditionally render navigation and content accordingly.

Changes

Cohort / File(s) Summary
Build & Development Configuration
package.json, playwright.config.ts
Added dev:app npm script and updated Playwright webServer command to prepend VITE_ENABLE_APP_ROUTES_IN_BROWSER=true environment variable.
Runtime Detection Utilities
src/shared/runtimeTarget.ts, src/vite-env.d.ts
Added new isTauriApp() and isMarketingWebsite() functions to detect execution environment; defined VITE_ENABLE_APP_ROUTES_IN_BROWSER environment variable type.
App Routing & Layout
src/App.tsx, src/shared/ui/TopMenu.tsx
Conditionally disable /setup, /dashboard, /settings routes and StartupDashboardRedirect when marketingSite is true; split navigation links into appNavLinks and marketingNavLinks with conditional rendering.
Landing & Settings Pages
src/pages/LandingPage.tsx, src/pages/SettingsPage.tsx
Updated LandingPage to show DownloadLatestButton and new "About" section when marketingSite is true; extracted about/contact/privacy sections from SettingsPage into new AboutLegalContent component.
Reusable About Component
src/shared/about/AboutLegalContent.tsx
New component that consolidates contact info, privacy info, and app version display with data-testid attributes for testing.

Sequence Diagram(s)

sequenceDiagram
    participant Browser as Browser Init
    participant RT as runtimeTarget
    participant App as App.tsx
    participant UI as TopMenu/Routes
    participant Landing as LandingPage

    Browser->>RT: Check window.__TAURI_INTERNALS__
    RT->>RT: isTauriApp() returns false (browser env)
    Browser->>RT: Check import.meta.env.VITE_ENABLE_APP_ROUTES_IN_BROWSER
    RT->>RT: isMarketingWebsite() returns true (flag not set)
    Browser->>App: Render with marketingSite=true
    App->>UI: StartupDashboardRedirect disabled
    App->>UI: /setup, /dashboard, /settings routes hidden
    App->>Landing: Render LandingPage
    Landing->>Landing: Show DownloadLatestButton instead of /setup link
    Landing->>Landing: Render "About" section with AboutLegalContent
    UI->>UI: TopMenu displays marketingNavLinks only
Loading

Estimated Code Review Effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly Related PRs

Poem

🐰 A hop through routes with browser cheer,
Where Tauri apps and marketing dwell here,
No setup-dash when marketing's the way,
Just download buttons bright to save the day!
Thump-thump goes the conditional flow. ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 80-bug-dashboard-and-setting-not-in-website

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Dashboard and Setting not in website

1 participant