K8SPG-1039 Add perconapgrestores/finalizers permission#1605
Merged
Conversation
Signed-off-by: Mayank Shah <mayank.shah@percona.com>
valmiranogueira
approved these changes
May 19, 2026
Contributor
valmiranogueira
left a comment
There was a problem hiding this comment.
Verified on openshift
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the operator’s RBAC to allow updating/patching perconapgrestores/finalizers, which is required when controllers add/remove finalizers on PerconaPGRestore resources.
Changes:
- Add
perconapgrestores/finalizersto kubebuilder RBAC markers. - Extend generated/static RBAC manifests (Role/ClusterRole and bundles) to include
perconapgrestores/finalizers.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| percona/controller/pgbackup/controller.go | Adds a kubebuilder RBAC marker for perconapgrestores/finalizers. |
| deploy/rbac.yaml | Adds perconapgrestores/finalizers to namespaced Role resources list. |
| deploy/cw-rbac.yaml | Adds perconapgrestores/finalizers to ClusterRole resources list. |
| deploy/cw-bundle.yaml | Propagates the RBAC resource addition into the CW bundle. |
| deploy/bundle.yaml | Propagates the RBAC resource addition into the main bundle. |
| config/rbac/namespace/role.yaml | Adds perconapgrestores/finalizers to generated namespace Role. |
| config/rbac/cluster/role.yaml | Adds perconapgrestores/finalizers to generated ClusterRole. |
| // +kubebuilder:rbac:groups=pgv2.percona.com,resources=perconapgbackups/status,verbs=create;patch;update | ||
| // +kubebuilder:rbac:groups=pgv2.percona.com,resources=perconapgclusters,verbs=get;list;create;update;patch;watch | ||
| // +kubebuilder:rbac:groups=pgv2.percona.com,resources=perconapgbackups/finalizers,verbs=update;patch | ||
| // +kubebuilder:rbac:groups=pgv2.percona.com,resources=perconapgrestores/finalizers,verbs=update;patch |
Collaborator
commit: 8624368 |
hors
approved these changes
May 19, 2026
hors
approved these changes
May 19, 2026
valmiranogueira
pushed a commit
that referenced
this pull request
May 19, 2026
Signed-off-by: Mayank Shah <mayank.shah@percona.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
Short explanation of the problem.
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability