Fix macOS launchctl pmcd fork issue #2425
Open
+571
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run pmcd in foreground mode when launched by launchctl to prevent the parent process exit after fork from being interpreted as a crash. - Add PMCD_LAUNCHED_BY_LAUNCHD env var in io.pcp.pmcd.plist - Enable KeepAlive for proper process monitoring - Detect env var in rc_pmcd and add -f flag to run in foreground
Adds automated test script and manual testing guide for validating the launchctl pmcd fork issue fix on macOS systems. - test-pmcd-launchctl.sh: Comprehensive automated test suite with proper timeout handling for slow VMs (3-minute timeouts) - TESTING.md: Manual testing procedures and troubleshooting guide Tests validate foreground mode operation, KeepAlive functionality, and proper launchctl service management. Placed in build/mac/qa/ to keep macOS-specific tests separate from the main qa/ suite. Not included in macOS package distribution (consistent with macOS installer excluding test infrastructure).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2307 - pmcd now runs in foreground mode when launched by launchctl on macOS, preventing the parent process exit after fork from being interpreted as a crash.
Changes
PMCD_LAUNCHED_BY_LAUNCHDenvironment variable and enabledKeepAlive-fflag to run pmcd in foreground modeBenefits
-fflag)Test Plan
See test plan below - validation needed on macOS with launchctl.