Edit form HOC refactor#597
Merged
camdendotlol merged 2 commits intodevelopfrom Apr 15, 2026
Merged
Conversation
blms
approved these changes
Apr 15, 2026
Contributor
blms
left a comment
There was a problem hiding this comment.
This looks great!
Could we open an issue, either here or in react-components, for propagating the necessary changes there (and for pulling out any code from here that would be duplicated)—including a basic outline for what needs to be done? Just want to make sure it stays on our radar.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses an issue exposed (but not caused) by the Clerk migration where the edit forms were being defined by a stack of HOCs and HOC-style hooks whose component definitions were not stable when the parent component re-rendered, meaning the form would get remounted every time its parent re-rendered. This never came up before the Clerk migration, because there was nothing that would cause the forms to re-render prior to the user clicking save. But Clerk refreshes its token periodically, causing
ClerkProvider(and all its children) to re-render. This meant that these fragile HOC-based forms would periodically unmount, resetting their state including unsaved user input.The refactor includes copying
EditContainerandEditPagefromreact-componentsto the CD codebase. Since this is a pretty dramatic change to the code and also the API surface of those components, I decided it wasn't worth taking the time to do a bunch of refactoring on the RC side yet.This PR also includes a few changes to make the Clerk authentication logic more robust.