Skip to content

Add faircopy_cloud_project_id field to project config form#598

Draft
ajolipa wants to merge 3 commits intodevelopfrom
RB-add-fcc2-support
Draft

Add faircopy_cloud_project_id field to project config form#598
ajolipa wants to merge 3 commits intodevelopfrom
RB-add-fcc2-support

Conversation

@ajolipa
Copy link
Copy Markdown
Contributor

@ajolipa ajolipa commented Apr 16, 2026

In this PR

Adds a faircopy_cloud_project_id field to the project configuration form, to enable support of FairCopy Cloud 2 projects (which require this parameter in the URL endpoint to fetch the CSV artifacts for import to Fairdata).

Notes

Should be merged after performant-software/core-data-connector#198 and should also include upgrading the core-data-connector gem to a new version with those changes, hence why I'm leaving this as a draft for the moment.

@ajolipa ajolipa requested review from blms and camdendotlol April 16, 2026 14:34
@NickLaiacona
Copy link
Copy Markdown
Member

@ajolipa the counterpart PR has been merged, however, it looks like you need to copy the migration 20260416013801_add_fcc2_project_id_to_projects.rb into this PR as well, otherwise it doesn't update the DB for the main app.

@blms
Copy link
Copy Markdown
Contributor

blms commented Apr 30, 2026

You can use the following rails command to do that, after installing the updated gem:

bundle exec rails g core_data_connector:install

Comment thread client/src/types/Project.js Outdated
description: string,
discoverable: boolean,
faircopy_cloud_url: string,
faircopy_cloud_project_id: Number,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this really matters in Flow (as opposed to TypeScript, where it definitely does) but we should use lower-case number for number types as Number with a capital N refers to JS's number constructor: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good catch, VSCode must have auto capitalized it for some reason and I missed it. Fixed!

@ajolipa ajolipa requested a review from camdendotlol May 1, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants