Add faircopy_cloud_project_id field to project config form#598
Add faircopy_cloud_project_id field to project config form#598
faircopy_cloud_project_id field to project config form#598Conversation
|
@ajolipa the counterpart PR has been merged, however, it looks like you need to copy the migration |
|
You can use the following rails command to do that, after installing the updated gem: |
| description: string, | ||
| discoverable: boolean, | ||
| faircopy_cloud_url: string, | ||
| faircopy_cloud_project_id: Number, |
There was a problem hiding this comment.
Not sure if this really matters in Flow (as opposed to TypeScript, where it definitely does) but we should use lower-case number for number types as Number with a capital N refers to JS's number constructor: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number
There was a problem hiding this comment.
Oh good catch, VSCode must have auto capitalized it for some reason and I missed it. Fixed!
In this PR
Adds a
faircopy_cloud_project_idfield to the project configuration form, to enable support of FairCopy Cloud 2 projects (which require this parameter in the URL endpoint to fetch the CSV artifacts for import to Fairdata).Notes
Should be merged after performant-software/core-data-connector#198 and should also include upgrading the
core-data-connectorgem to a new version with those changes, hence why I'm leaving this as a draft for the moment.