Fixes #145 - Tests for python builds with unified_diff count#146
Closed
garyjohnson wants to merge 1 commit into
Closed
Fixes #145 - Tests for python builds with unified_diff count#146garyjohnson wants to merge 1 commit into
garyjohnson wants to merge 1 commit into
Conversation
Author
|
Failed but should be fixed by merging PR #139 |
garyjohnson
changed the title
garyjohnson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #145 . Using skipif to conditionally run different tests in Python >=2.7.10 <=3.2. Unfortunately because of this there's some test duplication. Happy to try something else if you think a different approach would be more appropriate.