(many) Upgrade to .NET 6#223
Conversation
5bca247 to
f19de1d
Compare
8436d86 to
0112a8c
Compare
| <CodeAnalysisRuleSet>$(SolutionDir)global.ruleset</CodeAnalysisRuleSet> | ||
| <TargetFramework>net5.0</TargetFramework> | ||
| <TargetFramework>net6.0</TargetFramework> | ||
| <SuppressTrimAnalysisWarnings>true</SuppressTrimAnalysisWarnings> |
There was a problem hiding this comment.
Suppressing trimmer analysis warnings might seem a bit foolish, but I'm not sure littering the code with tons of attributes to suppress them is really the way forward for us. Let's for now assume the "dynamic programming language" approach instead - let's catch errors with unit tests instead of static analysis. 🤪
Time will tell whether this is insane or simply a stroke of genius...
There was a problem hiding this comment.
Time will tell whether this is insane or simply a stroke of genius...
Well. It hit us in #347, making these trimming warnings be invisible by default... 😎 See #347 (comment).
There was a problem hiding this comment.
I think we should try to solve this. Created an issue to track the work related to it: #348
0112a8c to
133c324
Compare
No description provided.