Fix boxify_points to correctly use a negative buffer#170
Merged
perrygeo merged 1 commit intoperrygeo:masterfrom Aug 10, 2018
Merged
Fix boxify_points to correctly use a negative buffer#170perrygeo merged 1 commit intoperrygeo:masterfrom
perrygeo merged 1 commit intoperrygeo:masterfrom
Conversation
Contributor
Author
|
Not sure what is going on with the checks failing. Runs fine locally |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following line in the
boxify_pointsutils function was creating a positive buffer value since theminof the cell size dimensions is already a negative number. This was resulting in a buffered pixel box that would overlap with surrounding cells when usingall_touched.buff = -0.01 * min(rast.affine.a, rast.affine.e)