Merged
Conversation
Owner
Author
|
Python 3.8 is failing and I have no clue why. It's only the geopandas tests failing. FWIW Geopandas is now on minimum Python 3.10 and Python 3.8 is EOL as of this month. So my plan is to bump this project to min version 3.9 and remove it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fiona behavior changed slightly when opening GeoJSON strings. See Toblerity/Fiona#1455
We can work around this in a backwards compatible way by catching the
ValueErrorso that GeoJSON strings take thejson.loadscode path.